-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
@@ -17,9 +17,15 @@ matrix: | |||
- php: 5.5 | |||
env: | |||
- EXECUTE_CS_CHECK=true | |||
- php: 5.5 | |||
env: | |||
- SERVICE_MANAGER_VERSION="^2.7.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this. The correct is to test lowest version (composer --prefer-lowest) and newest versions. All versions released in the middle are expected to be compatible and fulfill the API contract.
When we should to test specific versions? When the code HAS an specific logic branch testing if some feature is available i.e. (component_version >= 5.0) ? new API : old API
. And this thing should be do with only 1 PHP version and not 5.5. and 5.6 whcih make me the following question?
Why PHP 7 and HHVM are not duplicated?
I think the test matrix proposed in this PR is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, OK, didn't know about --prefer-lowest (not my preference often ;) I've just been following what I've seen @weierophinney do in PRs for zend-i18n etc.
I noticed @ezimuel has done it slightly differently, with a SERVICE_MANAGER_V2=(true|false). So something like:
install:
- if [[ $SERVICE_MANAGER_V2 != 'true' ]]; then travis_retry composer install --no-interaction --ignore-platform-reqs ; fi
- if [[ $SERVICE_MANAGER_V2 == 'true' ]]; then travis_retry composer install --no-interaction --ignore-platform-reqs --prefer-lowest ; fi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/composer install/composer update/ - install doesn't do --prefer-lowest
Nice one @Maks3w ! That makes flipping between versions when testing locally one heck of lot easier too :) |
@Maks3w : doesn't look like the The fail is due to the minimum symfony/file version specified by php-cd-fixer, which is 2.1. The |
@weierophinney Probably is an issue with the cached dependencies. Could you detail what issues did you had so I could investigate? Recently I have refactored a Symfony Test suite from to test every Supported version (Currenlty 4) to only to test lowest and newest with the only issue of reset the cache. Previous: https://travis-ci.org/Maks3w/FR3DLdapBundle/builds/108739742 |
*/ | ||
public function __construct(ConfigInterface $configuration = null) | ||
public function __construct(ContainerInterface $parentLocator, array $config = []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First argument must also accept null for full BC with v2; I'll update that when merging. (Discovered this the hard way with zend-view 2.6.0.)
ServiceManager v2-v3 compatibility
This builds on #86 adding ServiceManager v2/v3 compatibility.
The v2 tests will fail pending zendframework/zend-validator#51