Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

[WIP] Migrate to ZF3 components #86

Closed
wants to merge 13 commits into from
Closed

[WIP] Migrate to ZF3 components #86

wants to merge 13 commits into from

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jan 8, 2016

ping @ezimuel
Work in progress

@@ -117,7 +117,7 @@ public function clearDefaultValidatorChain()
public function setInputFilterManager(InputFilterPluginManager $inputFilterManager)
{
$this->inputFilterManager = $inputFilterManager;
$serviceLocator = $this->inputFilterManager->getServiceLocator();
$serviceLocator = $this->inputFilterManager;
if ($serviceLocator && $serviceLocator instanceof ServiceLocatorInterface) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check required?

@Maks3w
Copy link
Member

Maks3w commented Jan 8, 2016

Since this PR is similar to the rest of SMv3 PRs I think we should release a beta version of SMv3.

Following SMv3 betas should be backward compatible.

/cc @weierophinney

@Maks3w Maks3w added the WIP label Jan 8, 2016
@weierophinney
Copy link
Member

I plan to tag v2.7.0 and v3 of the SM early next week, add we've finished
ironing out the migration issues. @ezimuel and I will then with up a plan
to update the various components to target v2.7 (which will allow usage in
both v2 and v3).
On Jan 8, 2016 9:14 AM, "Maks3w" notifications@github.com wrote:

Since this PR is similar to the rest of SMv3 PRs I think we should release
a beta version of SMv3.

Following SMv3 betas should be backward compatible.

/cc @weierophinney https://github.com/weierophinney


Reply to this email directly or view it on GitHub
#86 (comment)
.

@Maks3w
Copy link
Member

Maks3w commented Jan 8, 2016

Sincerely I don't like nothing raise dependencies from 2.5 to 2.7 like has been do with stdlib.

  1. Teorically should work with 2.5
  2. If we have introcuced by accident any bug or backward incompatibility change then we will have a new nightmare like the changes was done between 2.3 and 2.4

'inputfilter' => InputFilter::class,
'collection' => CollectionInputFilter::class,
];

protected $factories = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a docblock or inheritdoc

@kynx
Copy link
Contributor

kynx commented Jan 21, 2016

I think your max nesting error is caused by https://github.com/zendframework/zend-inputfilter/blob/develop/src/Factory.php#L316 - calling get() is returning an existing instance. The following does the trick for me:

$inputFilter = $this->getInputFilterManager()->build($type);

@kynx
Copy link
Contributor

kynx commented Jan 21, 2016

Scratch that - protected $shareByDefault = false; -> protected $sharedByDefault = false; in InputFilterManager is the correct thing to do methinks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants