Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

getFactory() passes $this to abstract factory canCreate() #78

Closed
kynx opened this issue Jan 23, 2016 · 0 comments
Closed

getFactory() passes $this to abstract factory canCreate() #78

kynx opened this issue Jan 23, 2016 · 0 comments
Assignees
@Ocramius
Labels
bug
Milestone
3.0.2

Comments

@kynx
Copy link
Contributor

kynx commented Jan 23, 2016

See:
https://github.com/zendframework/zend-servicemanager/blob/develop/src/ServiceManager.php#L611

... but when the factory is invoked, it get's $this->creationContext.

I'm not sure if this is intentional or not, but it causes infinite loops when the abstract factory tries to do a $services->get('foo') inside it's canCreate(). See the fail at: zendframework/zend-inputfilter#86
@kynx kynx mentioned this issue Jan 23, 2016
Closed
@Ocramius Ocramius added the bug label Jan 24, 2016
@Ocramius Ocramius self-assigned this Jan 24, 2016
@Ocramius Ocramius added this to the 3.0.2 milestone Jan 24, 2016
Ocramius added a commit that referenced this issue Jan 24, 2016
@Ocramius
#78 #79 - adding @group annotations to the newly introduced test case
e56e5e1
Ocramius added a commit that referenced this issue Jan 24, 2016
@Ocramius
#78 #79 - documenting patch changes in the changelog
3a55b8d
Ocramius added a commit that referenced this issue Jan 24, 2016
@Ocramius
Merge branch 'fix/#79-#78-creation-context-not-passed-to-abstract-fac…
ff488d0 
…tory' into develop

Forward port #78
Forward port #79
Ocramius added a commit that referenced this issue Jan 24, 2016
@Ocramius
#78 #79 - adding @group annotations to the newly introduced test case
2543eac
Ocramius added a commit that referenced this issue Jan 24, 2016
@Ocramius
#78 #79 - documenting patch changes in the changelog
8b845a9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
3.0.2
Development

No branches or pull requests
2 participants
@Ocramius @kynx