This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Support for internationalized email address local part #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checked if $email is not empty before passing it to idn_to_utf8
Avoiding warning in the last character zendframework/zend-barcode#28
And do refactoring
Xerkus
force-pushed
the
hotfix/internationalized-local-part
branch
from
1a0ffdb
to
7f8ab4d
Compare
Added expression to validate .hr IDN domains
add ibanRegExp for Belarus.
'BY' => 'BY[0-9]{2}[A-Z0-9]{4}[0-9]{4}[A-Z0-9]{16}'
https://www.nbrb.by/engl/payment/IBANBIC
Per https://discourse.zendframework.com/t/validatormanager-not-calling-custom-validator-factory/109/5?u=matthew the `validators` config key is not honored currently unless the application is within a zend-mvc context. This is due to the fact that `Zend\Validator\Module` wires configuration for the `Zend\ModuleManager\Listener\ServiceListener` in order to push merged service configuration into the plugin during bootstrap; no similar logic is available when not in a zend-mvc context, however. This patch fixes that situation by modifying the `ValidatorPluginManagerFactory` to do the following: - If a `ServiceListener` service exists, it returns the plugin manager immediately (old behavior). - Otherwise, it checks for the `config` service, and, if found, a `validators` key with an array value. When found, it feeds that value to a `Zend\ServiceManager\Config` instance and uses that to configure the plugin manager before returning it.
…e name Doesn't affect tests, but it removes a WTF.
- No ValidatorInterface instance was needed for last two test cases
…ifications Enable Travis CI slack notifications
fixed a bug where empty $email was passed to idn_to_utf8
Forward port zendframework#94
Update Code128.php
Use is_readable() to check if file is readable
Should return `self` for fluent interfaces, class name when returning new instance (immutable classes).
Updates `Hostname` validator TLD list.
Add PHP 7.2 support, drop HHVM Conflicts: .travis.yml
- Whitespace following `function` keyword
- Uses newlines and indentation to group conditional statements
Updates the zend-session requirement to v2.8+, to ensure compatibility with PHP 7.2.
…max in setOptions which is used by the constructor, use getter methods instead of options field in isValid, report NOT_COUNTABLE as a validation error rather than throwing an exception, and use `$this->` instead of `self::` for assertions in test case.
add IsCountable validator, to enforce type and count elements.
…x value Since there is no way to clear a `count`, this is the only way to ensure that behavior remains as expected when merging options from disparate sources.
…ized-local-part Support for internationalized email address local part
…part as an argument Allows the method to not rely on instance state.
weierophinney
approved these changes
Jul 26, 2017
weierophinney
added a commit
that referenced
this pull request
Jul 26, 2017
weierophinney
added a commit
that referenced
this pull request
Jul 26, 2017
|
Thanks, @Xerkus; merged to develop for release with 2.10.0. |
|
ugh, what is going on here with the commits and comments? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 6532 extends atext used in local part with non-ascii unicode support
I have no idea what am i doing here. It seems to be working, but it would be great if someone understanding unicode could verify.