Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add PHP 7.2 support, drop HHVM #175

Merged
merged 4 commits into from
Jul 25, 2017
Merged

Conversation

Slamdunk
Copy link
Contributor

  • Adopt recent .travis.yml ZF standards (zend-session/.travis.yml picked)
  • Drop HVVM
  • Test PHP 7.2
  • Add partial PHP 7.2 support
    1. idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated
    2. count(): Parameter must be an array or an object that implements Countable

@froschdesign
Copy link
Member

PHP Fatal error: Declaration of Zend\Session\AbstractContainer::offsetGet($key) must be compatible with & Zend\Stdlib\ArrayObject::offsetGet($key) in /home/travis/build/zendframework/zend-validator/vendor/zendframework/zend-session/src/AbstractContainer.php on line 27

https://travis-ci.org/zendframework/zend-validator/jobs/246138892#L347

@Ocramius
Copy link
Member

@Slamdunk
Copy link
Contributor Author

Already fixed with zendframework/zend-session#78, in fact DEPS=latest build passes:
https://travis-ci.org/zendframework/zend-validator/jobs/246138893

@froschdesign
Copy link
Member

@Ocramius and @Slamdunk
Right! (I was a bit too fast 🙈 )

@@ -109,7 +110,7 @@ public function getFiles($file = null)
*/
public function setFiles($files = [])
{
if (count($files) === 0) {
if ((is_array($files) || $files instanceof Countable) && count($files) === 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note

This bug highlights a higher priority bug in this method: the argument type isn't checked.
But to lessen the complexity of the PR and to speed up the next release, here I'm doing the minimum to get the code to work exactly like before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it seems I was wrong: https://3v4l.org/Efkoc
So I guess a $_FILES test case is missing; condition changed.

@weierophinney weierophinney added this to the 2.10.0 milestone Jul 19, 2017
@weierophinney weierophinney merged commit 407ee84 into zendframework:develop Jul 25, 2017
weierophinney added a commit that referenced this pull request Jul 25, 2017
Add PHP 7.2 support, drop HHVM

Conflicts:
	.travis.yml
weierophinney added a commit that referenced this pull request Jul 25, 2017
weierophinney added a commit that referenced this pull request Jul 25, 2017
@weierophinney
Copy link
Member

Thanks, @Slamdunk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants