-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The failing tests for the nightly build are related to https://travis-ci.org/zendframework/zend-inputfilter/jobs/245787768#L381 |
@froschdesign thank you, zendframework/zend-validator#175 |
zend-inputfilter/composer.json Line 18 in 9569f7e
And zend-validator compatibility with PHP 7.2 was introduced only in zend-validator ^2.10 release |
@Slamdunk Maybe then we should bump requirements in composer.json? |
This is a decision that I cannot take, only maintainers know the path of expected components support. |
Any ETA for merging this PR? |
@MatyCZ I'm merging it today, but it won't release yet, as I have a PR or two I'm sitting on for the 2.8.0 release (primarily waiting for docs). This cannot release in a bugfix release, as it drops support for HHVM. |
Add PHP 7.2 support, drop HHVM
Thanks, @Slamdunk! |
.travis.yml
ZF standards (zend-session/.travis.yml picked)Fatal error: Declaration of Zend\InputFilter\CollectionInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /tmp/zend-inputfilter/src/CollectionInputFilter.php