Fix some refefinition issues #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmarull, please, rebase this when completed. |
gmarull
force-pushed
the
bit-redefinition-2
branch
5 times, most recently
from
b0bc35e to
818dfce
Compare
marekmatej
reviewed
Apr 12, 2023
| #include "sys/param.h" | ||
| #include "freertos/FreeRTOS.h" |
There was a problem hiding this comment.
I think you can remove the freertos.h include.
sys/param.h can't be used in Zephyr context, due to conflicts with MIN/MAX definitions. Sort headers so that Zephyr ones come first (so we avoid any potential conflicts with redefinitions). Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
When building for Zephyr, use sys/util.h. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
sys/param.h is not needed in some cases, in others, it conflicts with Zephyr so let's use Zephyr sys/util.h. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
The EMPTY enumeration collides with Zephyr EMPTY definition. Rename to EMPTY_STATE. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
The definition collides with Zephyr definition. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
gmarull
force-pushed
the
bit-redefinition-2
branch
from
818dfce to
e9c8665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNM