sys: util: force Zephyr BIT/MIN/MAX/CLAMP definitions #56629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
gmarull
changed the title
gmarull
requested review from
glaubermaroto,
LucasTambor,
kgugala and
pgielda
as code owners
zephyrbot
added
manifest
manifest-hal_nxp
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
@gmarull, hal_espressif PR merged. I'll approve when this PR manifest gets update as well. |
gmarull
force-pushed
the
no-ifndef-util
branch
2 times, most recently
from
2401aa4 to
4bcec20
Compare
gmarull
force-pushed
the
no-ifndef-util
branch
2 times, most recently
from
bf73a0f to
90605bf
Compare
- Sort includes - Remove some Kernel internal includes - Make sure Zephyr headers come first, so Zephyr's BIT() doesn't conflict with HAL. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
Avoid redefinition errors due to HAL defining BIT() macro in public headers. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
We've been guarding the definition of BIT/MIN/MAX/CLAMP macros as they are commonly found in other projects. This is dangerous, because depending on the order of includes, Zephyr code could end up using macros defined by other projects (e.g. via HALs). The current #ifndef _protection_ goes against the recently established guidelines in zephyrproject-rtos#51963, so let's remove it. Ref. https://docs.zephyrproject.org/latest/contribute/coding_guidelines/ index.html#rule-a-3-macro-name-collisions Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been guarding the definition of BIT/MIN/MAX/CLAMP macros as they are commonly found in other projects. This is dangerous, because depending on the order of includes, Zephyr code could end up using macros defined by other projects (e.g. via HALs).
The current #ifndef protection goes against the recently established guidelines in #51963, so let's remove it.
Ref. https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-3-macro-name-collisions