Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cfb: text is not displayed due to display_blanking_off() #13609

Closed
KwonTae-young opened this issue Feb 21, 2019 · 0 comments · Fixed by #13630
Closed

samples: cfb: text is not displayed due to display_blanking_off() #13609

KwonTae-young opened this issue Feb 21, 2019 · 0 comments · Fixed by #13630
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@KwonTae-young
Copy link
Collaborator

Describe the bug
samples/display/cfb uses display_blanking_off().

	}

	cfb_framebuffer_clear(dev, true);

	display_blanking_off(dev);

So text does not appear on the screen.
Instead of display_blanking_off(), use display_blanking_on() to display text.

To Reproduce
Board: frdm_k64f
SSD1306 Module: Adafruit PiOLED - 128x32 Monochrome OLED Add-on for Raspberry Pi

There is currently an I2C driver bug.(#8684)
The patch for #8684 (comment) needs to be applied.

mkdir samples/display/cfb/build
cd samples/display/cfb/build/
cmake -DBOARD=frdm_k64f ..
make -j8 flash

image

Expected behavior
I expected text to be displayed as below.
image

Impact
OLED is not displayed through samples/display/cfb.

Screenshots or console output
Corrected as shown below to display normally.

diff --git a/samples/display/cfb/src/main.c b/samples/display/cfb/src/main.c
index c314cbe419..a21b03ed01 100644
--- a/samples/display/cfb/src/main.c
+++ b/samples/display/cfb/src/main.c
@@ -50,7 +50,7 @@ void main(void)
 
        cfb_framebuffer_clear(dev, true);
 
-       display_blanking_off(dev);
+       display_blanking_on(dev);
 
        rows = cfb_get_display_parameter(dev, CFB_DISPLAY_ROWS);
        ppt = cfb_get_display_parameter(dev, CFB_DISPLAY_PPT);

It works even if it is modified as below.

diff --git a/samples/display/cfb/src/main.c b/samples/display/cfb/src/main.c
index c314cbe419..7411874e1b 100644
--- a/samples/display/cfb/src/main.c
+++ b/samples/display/cfb/src/main.c
@@ -50,8 +50,6 @@ void main(void)
 
        cfb_framebuffer_clear(dev, true);
 
-       display_blanking_off(dev);
-
        rows = cfb_get_display_parameter(dev, CFB_DISPLAY_ROWS);
        ppt = cfb_get_display_parameter(dev, CFB_DISPLAY_PPT);

Below is a running video.
Video: https://youtu.be/ovqmP0oC_5U

Environment:

  • OS: Linux(Ubuntu 18.04)
  • Toolchain: Zephyr SDK 0.9.5
  • Commit SHA: 662b44e

Additional context
display_blanking_off(dev); has been added at eef1099

I'm sorry I do not have enough English.
Thank you.

@KwonTae-young KwonTae-young added the bug The issue is a bug, or the PR is fixing a bug label Feb 21, 2019
@nashif nashif added the priority: low Low impact/importance bug label Feb 21, 2019
vanwinkeljan added a commit to vanwinkeljan/zephyr that referenced this issue Feb 21, 2019
Swapped mapping of SSD1306 display driver functions on display
blanking API.

fixes zephyrproject-rtos#13609

Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
galak pushed a commit that referenced this issue Feb 21, 2019
Swapped mapping of SSD1306 display driver functions on display
blanking API.

fixes #13609

Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants