Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: ssd1306: Corrected API mapping for blanking #13630

Merged
merged 1 commit into from
Feb 21, 2019
Merged

drivers: ssd1306: Corrected API mapping for blanking #13630

merged 1 commit into from
Feb 21, 2019

Conversation

vanwinkeljan
Copy link
Member

Swapped mapping of SSD1306 display driver functions on display
blanking API.

fixes #13609

@vanwinkeljan
drivers: ssd1306: Corrected API mapping for blanking
ddffdf7 
Swapped mapping of SSD1306 display driver functions on display
blanking API.

fixes zephyrproject-rtos#13609

Signed-off-by: Jan Van Winkel <jan.van_winkel@dxplore.eu>
@vanwinkeljan vanwinkeljan added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Feb 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #13630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13630   +/-   ##
=======================================
  Coverage   52.45%   52.45%           
=======================================
  Files         322      322           
  Lines       46595    46595           
  Branches    10771    10771           
=======================================
  Hits        24442    24442           
  Misses      17250    17250           
  Partials     4903     4903

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b644e...ddffdf7. Read the comment docs.

@galak galak merged commit e66cbb6 into zephyrproject-rtos:master Feb 21, 2019
@vanwinkeljan vanwinkeljan deleted the fix_ssd1306_blanking branch February 21, 2019 23:15
@KwonTae-young
Copy link
Collaborator

Hi. @vanwinkeljan
I have a question.
I thought samples/display/cfb should be modified.
However, the API mapping of the SSD1306 driver has changed.

The SSD1306 datasheet is marked as follows.
image

Now, display_blanking_on() will execute SSD1306_DISPLAY_OFF(0xAE).
display_blanking_off() will execute SSD1306_DISPLAY_ON(0xAF).
I think this is the opposite.

Is there something I do not know?

I'm sorry I do not have enough English.
Thank you.

@vanwinkeljan
Copy link
Member Author

The API display_blanking_on will turn blanking on or in other words turn the display panel off, display_blanking_off will turn blanking off (turn display panel on)

So the CFB example is correct as it turns blanking off by calling ````display_blanking_off```

@KwonTae-young
Copy link
Collaborator

@vanwinkeljan thanks. I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galak galak galak approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@nashif nashif Awaiting requested review from nashif

Assignees
No one assigned
Labels
Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

samples: cfb: text is not displayed due to display_blanking_off()
5 participants
@vanwinkeljan @codecov-io @KwonTae-young @jfischer-no @galak