Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devicetree: nRF5340 application core DTSI is missing cryptocell node #25493

Closed
mbolivar-nordic opened this issue May 20, 2020 · 0 comments · Fixed by #25494
Closed

devicetree: nRF5340 application core DTSI is missing cryptocell node #25493

mbolivar-nordic opened this issue May 20, 2020 · 0 comments · Fixed by #25494
Assignees
@mbolivar-nordic
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone
v2.3.0

Comments

@mbolivar-nordic
Copy link
Contributor

Describe the bug

The nRF5340 SoC's application core has a cryptocell peripheral, but this is not available in the corresponding DTSI.

Now that entropy sources have moved to DTS's zephyr,entropy chosen node from Kconfig's CONFIG_ENTROPY_NAME, this means users can no longer easily instantiate devices for managing the cryptocell in a way that interoperates with the rest of the system.

Expected behavior

nrf5340_cpuapp.dtsi should have nodes for all hardware addressable from the secure world.

Impact

Showstopper for "standard zephyr" entropy use on this core.

Environment (please complete the following information):

  • Commit SHA or Version used: v2.3.0-rc1 for example
@mbolivar-nordic mbolivar-nordic added bug The issue is a bug, or the PR is fixing a bug area: Devicetree labels May 20, 2020
@mbolivar-nordic mbolivar-nordic self-assigned this May 20, 2020
@mbolivar-nordic mbolivar-nordic added this to the v2.3.0 milestone May 20, 2020
@mbolivar-nordic mbolivar-nordic added the priority: medium Medium impact/importance bug label May 20, 2020
@mbolivar-nordic mbolivar-nordic mentioned this issue May 20, 2020
Merged
mbolivar-nordic added a commit to mbolivar-nordic/zephyr that referenced this issue May 20, 2020
@mbolivar-nordic
dts: nrf5340_cpuapp: add cryptocell node
263a434 
Add the missing node and bindings. This is a secure-mapped peripheral,
so do not add it to the common include file
nrf5340_cpuapp_common.dtsi.

Fixes: zephyrproject-rtos#25493
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
carlescufi pushed a commit that referenced this issue May 21, 2020
@mbolivar-nordic @carlescufi
dts: nrf5340_cpuapp: add cryptocell node
c0fcff9 
Add the missing node and bindings. This is a secure-mapped peripheral,
so do not add it to the common include file
nrf5340_cpuapp_common.dtsi.

Fixes: #25493
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
krip-tip pushed a commit to krip-tip/zephyr-local that referenced this issue May 30, 2020
@mbolivar-nordic
dts: nrf5340_cpuapp: add cryptocell node
46a6806 
Add the missing node and bindings. This is a secure-mapped peripheral,
so do not add it to the common include file
nrf5340_cpuapp_common.dtsi.

Fixes: zephyrproject-rtos#25493
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
kkasperczyk-no pushed a commit to kkasperczyk-no/zephyr that referenced this issue Jun 15, 2020
@mbolivar-nordic
[nrf fromtree] dts: nrf5340_cpuapp: add cryptocell node
a496e37 
Add the missing node and bindings. This is a secure-mapped peripheral,
so do not add it to the common include file
nrf5340_cpuapp_common.dtsi.

Fixes: zephyrproject-rtos#25493
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
(cherry picked from commit 1968930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbolivar-nordic mbolivar-nordic

Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

dts: nrf5340_cpuapp: add cryptocell node mbolivar-nordic/zephyr
1 participant
@mbolivar-nordic