Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: nrf5340_cpuapp: add cryptocell node #25494

Merged

Conversation

mbolivar-nordic
Copy link
Contributor

Add the missing node. This is a secure-mapped peripheral, so do not
add it to the common include file nrf5340_cpuapp_common.dtsi.

Fixes: #25493

@mbolivar-nordic
Copy link
Contributor Author

Do not merge without @frkv approval

@mbolivar-nordic mbolivar-nordic added this to the v2.3.0 milestone May 20, 2020
@mbolivar-nordic mbolivar-nordic added area: Devicetree bug The issue is a bug, or the PR is fixing a bug labels May 20, 2020
@mbolivar-nordic mbolivar-nordic requested a review from galak May 20, 2020 16:46
Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 312?

@mbolivar-nordic mbolivar-nordic force-pushed the dt-nrf53-crypto-nodes branch from 9680467 to f44bbe8 Compare May 20, 2020 20:14
@zephyrbot
Copy link
Collaborator

zephyrbot commented May 20, 2020

All checks passed.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@mbolivar-nordic mbolivar-nordic requested a review from ioannisg May 20, 2020 20:18
@galak
Copy link
Collaborator

galak commented May 20, 2020

Seems like you now need a binding for arm,cryptocell-312 & nordic,nrf-cc312

Add the missing node and bindings. This is a secure-mapped peripheral,
so do not add it to the common include file
nrf5340_cpuapp_common.dtsi.

Fixes: zephyrproject-rtos#25493
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
@mbolivar-nordic mbolivar-nordic force-pushed the dt-nrf53-crypto-nodes branch from f44bbe8 to 263a434 Compare May 20, 2020 20:23
@mbolivar-nordic mbolivar-nordic requested a review from anangl as a code owner May 20, 2020 20:23
@mbolivar-nordic
Copy link
Contributor Author

Seems like you now need a binding for arm,cryptocell-312 & nordic,nrf-cc312

yep, done now

@mbolivar-nordic
Copy link
Contributor Author

@ioannisg care to take another look?

@carlescufi carlescufi merged commit c0fcff9 into zephyrproject-rtos:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devicetree: nRF5340 application core DTSI is missing cryptocell node
7 participants