Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :219508] Unchecked return value in lib/libc/minimal/source/stdlib/malloc.c #32938

Closed
zephyrbot opened this issue Mar 5, 2021 · 1 comment · Fixed by #32993
Closed

[Coverity CID :219508] Unchecked return value in lib/libc/minimal/source/stdlib/malloc.c #32938

zephyrbot opened this issue Mar 5, 2021 · 1 comment · Fixed by #32993
Assignees
@npitre
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/lib/libc/minimal/source/stdlib/malloc.c

Category: Error handling issues
Function: free
Component: libc
CID: 219508

Details:

zephyr/lib/libc/minimal/source/stdlib/malloc.c

Line 90 in bd97359

sys_mutex_lock(&z_malloc_heap_mutex, K_FOREVER);

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Mar 5, 2021
@gudnimg gudnimg mentioned this issue Mar 5, 2021
Merged
@npitre
Copy link
Collaborator

npitre commented Mar 18, 2021

Should be covered by PR #33439

@npitre npitre mentioned this issue Mar 18, 2021
Closed
carlescufi pushed a commit that referenced this issue Mar 23, 2021
@gudnimg @carlescufi
lib: libc: minimal: add check on returned value
952970d 
Fix #32938 [Coverity CID :219508] "Unchecked return value in
lib/libc/minimal/source/stdlib/malloc.c"

The Coverity complains about sys_mutex_lock() which returns 0 if
locked. I added also the same check on returned value for
sys_mutex_unlock() which returns 0 if unlocked.

Signed-off-by: Guðni Már Gilbert <gudni.m.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npitre npitre

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: libc: minimal: add check on returned value
2 participants
@npitre @zephyrbot