libc/minimal: small fixes to malloc() and friends #33439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When malloc() is called with a size of 0 we should not set errno to ENOMEM as there is no actual allocation failure in that case. This duplicates the realloc() behavior. Check the return value of sys_mutex_lock() in the free() case to make Coverity happy. Replace all CHECKIF() by explicit assertion statements to uniformize those checks with the free() case which can't return errors. Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
|
Superseded by #33630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When malloc() is called with a size of 0 we should not set errno to
ENOMEM as there is no actual allocation failure in that case. This
duplicates the realloc() behavior.
Check the return value of sys_mutex_lock() in the free() case to make
Coverity happy (issue #32938).
Replace all CHECKIF() by explicit assertion statements to uniformize
those checks with the free() case which can't return errors. In theory
sys_mutex_lock() will never return an error here anyway.