Fix posix newlib / disable posix lib on native_posix arch #13540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
requested review from
nniranjhana,
pfalcon and
ramakrishnapallala
as code owners
galak
changed the title
galak
added
area: POSIX
|
@vanti this should address the issue you reported in: |
Codecov Report
@@ Coverage Diff @@
## master #13540 +/- ##
==========================================
- Coverage 52.45% 52.27% -0.19%
==========================================
Files 322 300 -22
Lines 46592 45032 -1560
Branches 10768 10421 -347
==========================================
- Hits 24442 23541 -901
+ Misses 17247 16772 -475
+ Partials 4903 4719 -184
Continue to review full report at Codecov.
|
|
recheck |
pfalcon
approved these changes
Feb 20, 2019
|
Closing/reopening to get rid of CI timing test glitch. |
|
For now we are disabling support for POSIX lib on native posix arch. We need to cleanup and support POSIX lib cleanly for hardware targets. Once that is working properly we can look to support the feature on native posix arch. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Both SDK 0.10.0-beta2 and the ARM gcc 2018q2 run into a build issue with newlib and conflict definitions of mode_t type. First we need to add some ifdef protection if mode_t is already defined and set _MODE_T_DECLARED if we are the first to define it. Secondarily, we rename include/posix/sys/types.h to include/posix/posix_types.h so that we aren't getting a name collusion with the system sys/types.h and that we can easily and clearily include it (which we need to do to pull in the info from newlib). Fixes: zephyrproject-rtos#12224 Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
galak
force-pushed
the
fix-posix-newlib
branch
from
ec29f55 to
2b11888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.