Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with both pthread and newlib enabled #13599

Closed
wants to merge 1 commit into from

Conversation

vanti
Copy link
Collaborator

@vanti vanti commented Feb 20, 2019

This commit adds a test case that reproduces sdk-ng#45.

Signed-off-by: Vincent Wan vincent.wan@linaro.org

@vanti vanti requested a review from pfalcon as a code owner February 20, 2019 22:48
@vanti vanti requested a review from galak February 20, 2019 22:48
@vanti vanti force-pushed the test_13540 branch 2 times, most recently from 643be36 to 9435a26 Compare February 20, 2019 22:58
@zephyrproject-rtos zephyrproject-rtos deleted a comment from zephyrbot Feb 20, 2019
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 20, 2019

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

tests:
portability.posix:
tags: posix
min_ram: 64
Copy link
Collaborator

@galak galak Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should exclude native_posix:

arch_exclude: posix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the toolchain supporting newlib:

filter: TOOLCHAIN_HAS_NEWLIB == 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

This commit adds a test case that reproduces sdk-ng#45.

Signed-off-by: Vincent Wan <vincent.wan@linaro.org>
@codecov-io
Copy link

Codecov Report

Merging #13599 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13599   +/-   ##
=======================================
  Coverage   52.45%   52.45%           
=======================================
  Files         322      322           
  Lines       46592    46592           
  Branches    10768    10768           
=======================================
  Hits        24442    24442           
  Misses      17247    17247           
  Partials     4903     4903

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c9a6a...d63d5b8. Read the comment docs.

@galak
Copy link
Collaborator

galak commented Feb 22, 2019

Closing this in favor of #13685

@galak galak closed this Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants