Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: arm: aarch32: rename z_arm_lib_init() function #23421

Conversation

ioannisg
Copy link
Member

@ioannisg ioannisg commented Mar 12, 2020

We rename the z_arm_lib_init() function to
z_arm_interrupt_init(), aligning to how other
ARCHes name their IRQ initialization function.
There is nothing about 'library' in this
functionality, so we remove the 'lib' in-fix.

The commit does not introduce any behavior changes.

Helper for #22718

Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no

@ioannisg ioannisg requested a review from stephanosio March 12, 2020 12:44
@ioannisg ioannisg added area: ARM ARM (32-bit) Architecture Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Mar 12, 2020
@ioannisg ioannisg self-assigned this Mar 12, 2020
@ioannisg ioannisg added this to the v2.3.0 milestone Mar 12, 2020
@zephyrbot zephyrbot added the area: API Changes to public APIs label Mar 12, 2020
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to fix the commit message to mention the correct old name for the sake of future reference.

s/z_arm_lib_init/z_arm_int_lib_init/

@ioannisg
Copy link
Member Author

It would be helpful to fix the commit message to mention the correct old name for the sake of future reference.

s/z_arm_lib_init/z_arm_int_lib_init/

Will fix, thanks.

We rename the z_arm_int_lib_init() function to
z_arm_interrupt_init(), aligning to how other
ARCHes name their IRQ initialization function.
There is nothing about 'library' in this
functionality, so we remove the 'lib' in-fix.

The commit does not introduce any behavior changes.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg ioannisg force-pushed the arch_arm_aarch32_minor_function_rename branch from f8db8b0 to 4c2e6bd Compare March 12, 2020 14:27
@ioannisg
Copy link
Member Author

Fixed @stephanosio

@andrewboie andrewboie merged commit d9a6e1d into zephyrproject-rtos:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: ARM ARM (32-bit) Architecture Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants