libc/minimal: assorted fixes to malloc() and friends #33630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
approved these changes
Mar 30, 2021
andyross
approved these changes
Mar 30, 2021
- When malloc() is called with a size of 0 we should not set errno to ENOMEM as there is no actual allocation failure in that case. This duplicates the realloc() behavior. - Put unlock_ret assignments on separate lines, otherwise gcc complains about unused variables when the tests on it are disabled. - There NULL return added in 952970d are completely pointless. First, there is no reason for sys_mutex_unlock() to fail, and even if it did, those returns would be blatent memory leaks. Remove them. No one should blindly modify code just to make static code analysers happy. - Replace all CHECKIF() by explicit assertion statements to uniformize those checks and drop the NULL returns entirely. We can't return anything in the free() case, and there are no runtime conditions for sys_mutex_lock() to sometimes succeed and sometimes fail anyway. Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When malloc() is called with a size of 0 we should not set errno
to ENOMEM as there is no actual allocation failure in that case.
This duplicates the realloc() behavior.
Put unlock_ret assignments on separate lines, otherwise gcc complains
about unused variables when the tests on it are disabled.
There NULL return added in 952970d are completely pointless.
First, there is no reason for sys_mutex_unlock() to fail, and even
if it did, those returns would be blatent memory leaks. Remove them.
No one should blindly modify code just to make static code
analysers happy.
Replace all CHECKIF() by explicit assertion statements to uniformize
those checks and drop the NULL returns entirely. We can't return
anything in the free() case anyway, and there are no runtime
conditions for sys_mutex_lock() to sometimes succeed and sometimes
fail anyway.
Signed-off-by: Nicolas Pitre npitre@baylibre.com