Fix the uart_ns16550.c buffer underflow issue. #34235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipengit
requested review from
aasthagr,
dcpleung,
jenmwms and
nashif
as code owners
jenmwms
approved these changes
Apr 14, 2021
|
Please resolve the patch compliance check issues before merge, though. Thanks! |
lipengit
force-pushed
the
patch-2
branch
4 times, most recently
from
d2f5a5a to
0fd6e18
Compare
Set DLAB bit before reading RDR to avoid buffer underflow. Signed-off-by: Peng Li <lipengit@gmail.com>
The patch compliance check issues have been solved. Thanks. |
dcpleung
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
driver: serial: uart_ns16550: fixed the buffer underflow issue when clearing the port.
To clear the port by reading the RDR register, the DLAB bit should be set, otherwise, the Synopsys UART IP reports a buffer underflow error.
Signed-off-by: Li, Peng lipengit@gmail.com
Fixes #34234