Added missing arduino definitions to nRF5340 Audio DK board #69794

smaerup · 2024-03-05T11:48:42Z

No description provided.

nordicjm · 2024-04-17T07:20:22Z

@koffes please review

koffes · 2024-04-24T14:09:11Z

Did anything change apart from a rebase and a rename in the last two force pushed @smaerup ?

smaerup · 2024-04-25T06:05:14Z

Did anything change apart from a rebase and a rename in the last two force pushed @smaerup ?
No, that is the only changes, the rename was needed because of the HWM2 switch.

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi

anangl · 2024-04-25T07:31:34Z

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi

+	cs-gpios = <&gpio0 11 GPIO_ACTIVE_LOW>, <&gpio0 17 GPIO_ACTIVE_LOW>,
+	           <&arduino_header 16 GPIO_ACTIVE_LOW>;


Suggested change

cs-gpios = <&gpio0 11 GPIO_ACTIVE_LOW>, <&gpio0 17 GPIO_ACTIVE_LOW>,

<&arduino_header 16 GPIO_ACTIVE_LOW>;

cs-gpios = <&arduino_header 16 GPIO_ACTIVE_LOW>,

<&gpio0 11 GPIO_ACTIVE_LOW>, <&gpio0 17 GPIO_ACTIVE_LOW>;

and adjust addresses in sdhc@0 and cs47l63@1 below. arduino_spi users (e.g. shields) will likely use CS #0, not #2.

Hi @anangl - could you please explain to a 'devicetree novice' like me? :)

anangl

Please fix the compliance check failure (use tab instead of 8 spaces).

zephyrbot · 2024-05-01T05:33:03Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

zephyrbot · 2024-05-01T05:33:03Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`cd046fa`	zephyrproject-rtos/hal_nxp@`8c354a9`	zephyrproject-rtos/hal_nxp@cd046faf..8c354a91
hal_renesas	zephyrproject-rtos/hal_renesas@`991e060`	zephyrproject-rtos/hal_renesas@`e3560c7` (main)	zephyrproject-rtos/hal_renesas@991e060b..e3560c79
mcuboot	zephyrproject-rtos/mcuboot@`24ac8cc`	zephyrproject-rtos/mcuboot@`78bfe75`	zephyrproject-rtos/mcuboot@24ac8cc2..78bfe750

Note: This message is automatically posted and updated by the Manifest GitHub Action.

larsgk

The previous merge issue seems fixed now

anangl · 2024-05-06T15:09:14Z

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi

@@ -137,23 +137,6 @@ arduino_i2c: &i2c1 {
 	pinctrl-0 = <&i2c1_default>;
 	pinctrl-1 = <&i2c1_sleep>;
 	pinctrl-names = "default", "sleep";
-};
-
-arduino_spi: &spi4 {


You should correct the commits. Currently, the second commit removes changes in boards/ that are just unnecessarily introduced by the first one.

The nRF5340 Audio DK board definition was missing Arduino Shield definitions. Signed-off-by: Tim Sørensen <tims@demant.com>

The adc_api test was missing an overlay file for the nRF5340 Audio Dk board. Signed-off-by: Tim Sørensen <tims@demant.com>

koffes · 2024-05-07T10:27:04Z

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi

 	pinctrl-0 = <&spi4_default>;
 	pinctrl-1 = <&spi4_sleep>;
 	pinctrl-names = "default", "sleep";
-	sdhc0: sdhc@0 {
+	sdhc0: sdhc@1 {


Why was this changed to 1?

It was suggested by anangl above that shield users will probably use CS0, hence sdhc and cs47l63 should be incremented by 1.

koffes · 2024-05-07T10:27:14Z

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi

@@ -191,7 +203,7 @@ arduino_serial: &uart1 {
 		spi-max-frequency = <8000000>;
 	};

-	cs47l63: cs47l63@1 {
+	cs47l63: cs47l63@2 {


Why was this changed to 2?

It was suggested by anangl above that shield users will probably use CS0, hence sdhc and cs47l63 should be incremented by 1.

github-actions · 2024-05-08T10:08:43Z

Hi @smaerup!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added area: ADC Analog-to-Digital Converter (ADC) platform: nRF Nordic nRFx labels Mar 5, 2024

zephyrbot requested review from anangl and decsny March 5, 2024 11:49

zephyrbot assigned anangl Mar 5, 2024

smaerup changed the title ~~Nrf5340 arduino defines~~ Added missing arduino definitions to nRF5340 Audio DK board Mar 5, 2024

smaerup force-pushed the nrf5340_arduino_defines branch from 2bc8d96 to 41a7bbc Compare March 6, 2024 07:17

MaureenHelm requested a review from nordicjm April 10, 2024 21:20

nordicjm requested a review from koffes April 11, 2024 06:42

decsny removed their request for review April 17, 2024 16:18

koffes approved these changes Apr 18, 2024

View reviewed changes

smaerup force-pushed the nrf5340_arduino_defines branch 2 times, most recently from 1cf9d8b to 771824b Compare April 23, 2024 11:41

smaerup requested a review from koffes April 23, 2024 12:55

larsgk previously approved these changes Apr 24, 2024

View reviewed changes

anangl requested changes Apr 25, 2024

View reviewed changes

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi Outdated Show resolved Hide resolved

boards/nordic/nrf5340_audio_dk/nrf5340_audio_dk_nrf5340_cpuapp_common.dtsi Outdated Show resolved Hide resolved

smaerup dismissed larsgk’s stale review via 2f50f88 April 25, 2024 07:03

smaerup force-pushed the nrf5340_arduino_defines branch from 771824b to 2f50f88 Compare April 25, 2024 07:03

smaerup requested review from anangl and larsgk April 25, 2024 07:04

anangl reviewed Apr 25, 2024

View reviewed changes

smaerup force-pushed the nrf5340_arduino_defines branch from 2f50f88 to 11d284c Compare April 25, 2024 12:59

smaerup requested a review from anangl April 25, 2024 12:59

zephyrbot requested review from kl-cruz, masz-nordic and nika-nordic April 25, 2024 13:00

anangl previously approved these changes Apr 25, 2024

View reviewed changes

zephyrbot added manifest manifest-hal_renesas manifest-hal_nxp manifest-mcuboot labels May 1, 2024

smaerup dismissed stale reviews from anangl and larsgk via 5830689 May 1, 2024 05:44

smaerup force-pushed the nrf5340_arduino_defines branch from 1797361 to 5830689 Compare May 1, 2024 05:44

zephyrbot removed manifest manifest-mcuboot manifest-hal_nxp manifest-hal_renesas labels May 1, 2024

larsgk previously approved these changes May 1, 2024

View reviewed changes

smaerup requested review from koffes and anangl May 6, 2024 08:29

anangl reviewed May 6, 2024

View reviewed changes

smaerup added 2 commits May 7, 2024 12:00

boards: added missing arduino defines to nRF5340 Audio DK board

4b9f382

The nRF5340 Audio DK board definition was missing Arduino Shield definitions. Signed-off-by: Tim Sørensen <tims@demant.com>

tests: drivers: adc: adc_api: added nRF5340 Audio DK overlay

89c3627

The adc_api test was missing an overlay file for the nRF5340 Audio Dk board. Signed-off-by: Tim Sørensen <tims@demant.com>

smaerup dismissed larsgk’s stale review via 89c3627 May 7, 2024 10:03

smaerup force-pushed the nrf5340_arduino_defines branch from 5830689 to 89c3627 Compare May 7, 2024 10:03

koffes reviewed May 7, 2024

View reviewed changes

anangl approved these changes May 7, 2024

View reviewed changes

smaerup requested review from koffes and larsgk May 7, 2024 13:34

larsgk approved these changes May 8, 2024

View reviewed changes

aescolar merged commit 98b996f into zephyrproject-rtos:main May 8, 2024
22 checks passed

smaerup deleted the nrf5340_arduino_defines branch May 8, 2024 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added missing arduino definitions to nRF5340 Audio DK board #69794

Added missing arduino definitions to nRF5340 Audio DK board #69794

smaerup commented Mar 5, 2024

nordicjm commented Apr 17, 2024

koffes commented Apr 24, 2024

smaerup commented Apr 25, 2024

anangl Apr 25, 2024 •

edited

Loading

larsgk Apr 25, 2024

anangl left a comment •

edited

Loading

zephyrbot commented May 1, 2024 •

edited

Loading

zephyrbot commented May 1, 2024

larsgk left a comment

anangl May 6, 2024

koffes May 7, 2024

smaerup May 7, 2024

koffes May 7, 2024

smaerup May 7, 2024

github-actions bot commented May 8, 2024

		cs-gpios = <&gpio0 11 GPIO_ACTIVE_LOW>, <&gpio0 17 GPIO_ACTIVE_LOW>,
		<&arduino_header 16 GPIO_ACTIVE_LOW>;

Added missing arduino definitions to nRF5340 Audio DK board #69794

Added missing arduino definitions to nRF5340 Audio DK board #69794

Conversation

smaerup commented Mar 5, 2024

nordicjm commented Apr 17, 2024

koffes commented Apr 24, 2024

smaerup commented Apr 25, 2024

anangl Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

larsgk Apr 25, 2024

Choose a reason for hiding this comment

anangl left a comment • edited Loading

Choose a reason for hiding this comment

zephyrbot commented May 1, 2024 • edited Loading

zephyrbot commented May 1, 2024

larsgk left a comment

Choose a reason for hiding this comment

anangl May 6, 2024

Choose a reason for hiding this comment

koffes May 7, 2024

Choose a reason for hiding this comment

smaerup May 7, 2024

Choose a reason for hiding this comment

koffes May 7, 2024

Choose a reason for hiding this comment

smaerup May 7, 2024

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

anangl Apr 25, 2024 •

edited

Loading

anangl left a comment •

edited

Loading

zephyrbot commented May 1, 2024 •

edited

Loading