Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSPX.cfg and StationPartsExpansionRedux.cfg are more or less identical MM patches #35

Closed
marr75 opened this issue Oct 28, 2021 · 1 comment · Fixed by #48
Closed

SSPX.cfg and StationPartsExpansionRedux.cfg are more or less identical MM patches #35

marr75 opened this issue Oct 28, 2021 · 1 comment · Fixed by #48
Assignees
@zer0Kerbal
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code

Comments

@marr75
Copy link

marr75 commented Oct 28, 2021

In pre-release 4.0.9.9, these two files add redundant workshop patches to SSPX/R centrifuges and inflatable habs.
@zer0Kerbal zer0Kerbal self-assigned this Oct 28, 2021
@zer0Kerbal zer0Kerbal added bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code Fix compatibility labels Oct 28, 2021
@zer0Kerbal zer0Kerbal added this to the 4.0.99.1-prerelease milestone Oct 28, 2021
@zer0Kerbal
Copy link
Owner

thank you @marr75 !
seems that an old version of the patch crept in when I git mv'd (renamed) the patch).
Is now fixed internally and I plan on releasing 4.0.99.1-prerelease shortly with other similar fixes.
again, thank you!

zer0Kerbal added a commit that referenced this issue Dec 2, 2021
@zer0Kerbal
Version 4.0.9.9.1-prerelease - A Bigger Hammer
1901820 
# Version 4.0.9.9.1-prerelease - A Bigger Hammer

# This is PRE-RELEASE - and WILL break saves

- 01 Dec 2021
- Release for Kerbal Space Program [KSP 1.12.2]

## DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL

## WARNING: Only [CurseForge][CRSFG:url] version will include .dll’s

# Removed

- duplicate patches (SSPX.cfg)

# GUI Icons

- customized app icon with permission from taniwha! thank you!

# Localization

- added Chinese [zh-cn.cfg]

# CurseForge/Overwolf

- corrected archive packaging for installer

# Backend
- folder maintenance
- moved Patches --> Compatibility
- update automation to latest version
- convert _release.json to schema 1.0.2.1

# Kerbal Changelog

- due to concerns about bloating the game and module manager .cache files
- therefor changelogs might be affecting game load times
- renamed to [Changelog.kcl] and updates have been suspended.

# [ScienceLabs.cfg] v1.0.2.1

- add FullyEquipped = true (might increase productivity factor)
- Lint and maintenance pass

# [ExperienceTraits.cfg] v1.0.0.1

- adjust patch [EXPERIENCE_TRAIT[Pilot]] in order to reduce log spam
- adjust patch [EXPERIENCE_TRAIT[Engineer]] in order to reduce log spam

# [Launchclamps.cfg] v1.0.2.0

- the clampBurgler has been caught and locked away.

# [Tanks.cfg] v1.0.1.0

- append '-ore' to stock tanks
- adjusted :NEEDS so always will create / modify, even if a switcher add on is installed
- added tags:BEFORE[SimpleConstruction]
- remov tags:BEFORE[SimpleConstruction]
- adjust tags part of part creation - replacing ore with either metal or rocketparts
- adjust timing of patches to ensure proper execution

# [DockingPorts.cfg] v1.0.2.0

- [ELLauchpad]
  - PadName = $#../Title# (to help self label Pads)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELTarget]
  - remove [TargetTransform]
  - remove [SpawnHeightOffset]
  - %TargetName = $#../Title# (to help self label Targets)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELWorkshop]
  - add UnManned Productivity = 0.25;
  - add IgnoreCrewCapacity = true;

# [CrewedPods.cfg] v1.0.1.1

- add to none command/crewed parts: FullyEquipped = true (might increase productivity factor)

### Status

- Issues/Milestones
 - closes #10 - Create SC Icon
 - closes #17 - 4.0.99.1-prerelease
 - closes #13 - 1.1.2.99-prerelease - two week CurseForge
 - closes #19 - Localization - master
 - closes #21 - Localization - Chinese
 - closes #34 - Localization - German
 - closes #35 - Duplicate patches
 - closes #36 - Launchclamps
 - updates #36 - Spawn location
 - closes #43 - Version
 - closes #44 - Legal MumboJumbo
 - closes #45 - Update documentation
 - closes #46 - Release 4.0.9.9.1-prerelease
 - closes #47 - Social Media
- Pull Requests
  - closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer
  - closes # - [ImgBot] Optimize images - contributed by imgbot[bot]
- *** Possible future changes ***
  - #40 - Stock Recycler
  and more

- [ELWorkshop]
  - newly discovered KSPFields
  - bool FullyEquipped;
  - bool - IgnoreCrewCapacity = true;
  - float - ProductivityFactor = 1f;
  - float - UnmannedProductivity;
@zer0Kerbal zer0Kerbal mentioned this issue Dec 2, 2021
Merged
zer0Kerbal added a commit that referenced this issue Dec 2, 2021
@zer0Kerbal
Merge pull request #48 from zer0Kerbal/4.0.9.9.1-prerelease
88dd4a3 
# Version 4.0.9.9.1-prerelease - A Bigger Hammer

# This is PRE-RELEASE - and WILL break saves

- 01 Dec 2021  
- Release for Kerbal Space Program [KSP 1.12.2] 

## DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL  

## WARNING: Only [CurseForge][CRSFG:url] version will include .dll’s

# Removed

- duplicate patches (SSPX.cfg)

# GUI Icons

- customized app icon with permission from taniwha! thank you!

# Localization

- added Chinese [zh-cn.cfg]

# CurseForge/Overwolf

- corrected archive packaging for installer

# Backend
- folder maintenance
- moved Patches --> Compatibility
- update automation to latest version
- convert _release.json to schema 1.0.2.1

# Kerbal Changelog

- due to concerns about bloating the game and module manager .cache files
- therefor changelogs might be affecting game load times
- renamed to [Changelog.kcl] and updates have been suspended.

# [ScienceLabs.cfg] v1.0.2.1

- add FullyEquipped = true (might increase productivity factor)
- Lint and maintenance pass

# [ExperienceTraits.cfg] v1.0.0.1

- adjust patch [EXPERIENCE_TRAIT[Pilot]] in order to reduce log spam
- adjust patch [EXPERIENCE_TRAIT[Engineer]] in order to reduce log spam

# [Launchclamps.cfg] v1.0.2.0

- the clampBurgler has been caught and locked away.

# [Tanks.cfg] v1.0.1.0

- append '-ore' to stock tanks
- adjusted :NEEDS so always will create / modify, even if a switcher add on is installed
- added tags:BEFORE[SimpleConstruction]
- remov tags:BEFORE[SimpleConstruction]
- adjust tags part of part creation - replacing ore with either metal or rocketparts
- adjust timing of patches to ensure proper execution
  
# [DockingPorts.cfg] v1.0.2.0

- [ELLauchpad]
  - PadName = $#../Title# (to help self label Pads)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELTarget]
  - remove [TargetTransform]
  - remove [SpawnHeightOffset]
  - %TargetName = $#../Title# (to help self label Targets)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELWorkshop]
  - add UnManned Productivity = 0.25; 
  - add IgnoreCrewCapacity = true;

# [CrewedPods.cfg] v1.0.1.1

- add to none command/crewed parts: FullyEquipped = true (might increase productivity factor)

### Status

- Issues/Milestones
 - closes #10 - Create SC Icon
 - closes #17 - 4.0.99.1-prerelease
 - closes #13 - 1.1.2.99-prerelease - two week CurseForge
 - closes #19 - Localization - master
 - closes #21 - Localization - Chinese
 - closes #34 - Localization - German
 - closes #35 - Duplicate patches
 - closes #36 - Launchclamps
 - updates #36 - Spawn location
 - closes #43 - Version 
 - closes #44 - Legal MumboJumbo 
 - closes #45 - Update documentation  
 - closes #46 - Release 4.0.9.9.1-prerelease 
 - closes #47 - Social Media 
- Pull Requests
  - closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer 
  - closes # - [ImgBot] Optimize images - contributed by imgbot[bot]
- *** Possible future changes ***
  - #40 - Stock Recycler
  and more

- [ELWorkshop]
  - newly discovered KSPFields
  - bool FullyEquipped;
  - bool - IgnoreCrewCapacity = true;
  - float - ProductivityFactor = 1f;
  - float - UnmannedProductivity;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.0.9.9.1 prerelease - A Bigger Hammer zer0Kerbal/SimpleConstruction
2 participants
@marr75 @zer0Kerbal