Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock Recycler #40

Closed
1 task
zer0Kerbal opened this issue Nov 24, 2021 · 7 comments · Fixed by #178
Closed
1 task

Stock Recycler #40

zer0Kerbal opened this issue Nov 24, 2021 · 7 comments · Fixed by #178
Assignees
@zer0Kerbal
Labels
issue: config issue type issue: external issue originates from external sources issue: model issue type issue: texture issue type state: won't fix No action will be taken at this time work: complex The situation is complex, emergent practices used.
Milestone
4.0.99.20-prerelease

Comments

@zer0Kerbal
Copy link
Owner

Add

  • adapt stock part to be EL Recycler
@zer0Kerbal zer0Kerbal added this to the Stock Recycler milestone Nov 24, 2021
@zer0Kerbal zer0Kerbal self-assigned this Nov 24, 2021
@zer0Kerbal
Copy link
Owner Author

what part? should it be an add module to or should it be a +PART (copy)?

zer0Kerbal added a commit that referenced this issue Dec 2, 2021
@zer0Kerbal
Version 4.0.9.9.1-prerelease - A Bigger Hammer
1901820 
# Version 4.0.9.9.1-prerelease - A Bigger Hammer

# This is PRE-RELEASE - and WILL break saves

- 01 Dec 2021
- Release for Kerbal Space Program [KSP 1.12.2]

## DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL

## WARNING: Only [CurseForge][CRSFG:url] version will include .dll’s

# Removed

- duplicate patches (SSPX.cfg)

# GUI Icons

- customized app icon with permission from taniwha! thank you!

# Localization

- added Chinese [zh-cn.cfg]

# CurseForge/Overwolf

- corrected archive packaging for installer

# Backend
- folder maintenance
- moved Patches --> Compatibility
- update automation to latest version
- convert _release.json to schema 1.0.2.1

# Kerbal Changelog

- due to concerns about bloating the game and module manager .cache files
- therefor changelogs might be affecting game load times
- renamed to [Changelog.kcl] and updates have been suspended.

# [ScienceLabs.cfg] v1.0.2.1

- add FullyEquipped = true (might increase productivity factor)
- Lint and maintenance pass

# [ExperienceTraits.cfg] v1.0.0.1

- adjust patch [EXPERIENCE_TRAIT[Pilot]] in order to reduce log spam
- adjust patch [EXPERIENCE_TRAIT[Engineer]] in order to reduce log spam

# [Launchclamps.cfg] v1.0.2.0

- the clampBurgler has been caught and locked away.

# [Tanks.cfg] v1.0.1.0

- append '-ore' to stock tanks
- adjusted :NEEDS so always will create / modify, even if a switcher add on is installed
- added tags:BEFORE[SimpleConstruction]
- remov tags:BEFORE[SimpleConstruction]
- adjust tags part of part creation - replacing ore with either metal or rocketparts
- adjust timing of patches to ensure proper execution

# [DockingPorts.cfg] v1.0.2.0

- [ELLauchpad]
  - PadName = $#../Title# (to help self label Pads)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELTarget]
  - remove [TargetTransform]
  - remove [SpawnHeightOffset]
  - %TargetName = $#../Title# (to help self label Targets)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELWorkshop]
  - add UnManned Productivity = 0.25;
  - add IgnoreCrewCapacity = true;

# [CrewedPods.cfg] v1.0.1.1

- add to none command/crewed parts: FullyEquipped = true (might increase productivity factor)

### Status

- Issues/Milestones
 - closes #10 - Create SC Icon
 - closes #17 - 4.0.99.1-prerelease
 - closes #13 - 1.1.2.99-prerelease - two week CurseForge
 - closes #19 - Localization - master
 - closes #21 - Localization - Chinese
 - closes #34 - Localization - German
 - closes #35 - Duplicate patches
 - closes #36 - Launchclamps
 - updates #36 - Spawn location
 - closes #43 - Version
 - closes #44 - Legal MumboJumbo
 - closes #45 - Update documentation
 - closes #46 - Release 4.0.9.9.1-prerelease
 - closes #47 - Social Media
- Pull Requests
  - closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer
  - closes # - [ImgBot] Optimize images - contributed by imgbot[bot]
- *** Possible future changes ***
  - #40 - Stock Recycler
  and more

- [ELWorkshop]
  - newly discovered KSPFields
  - bool FullyEquipped;
  - bool - IgnoreCrewCapacity = true;
  - float - ProductivityFactor = 1f;
  - float - UnmannedProductivity;
@zer0Kerbal zer0Kerbal mentioned this issue Dec 2, 2021
Merged
zer0Kerbal added a commit that referenced this issue Dec 2, 2021
@zer0Kerbal
Merge pull request #48 from zer0Kerbal/4.0.9.9.1-prerelease
88dd4a3 
# Version 4.0.9.9.1-prerelease - A Bigger Hammer

# This is PRE-RELEASE - and WILL break saves

- 01 Dec 2021  
- Release for Kerbal Space Program [KSP 1.12.2] 

## DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL  

## WARNING: Only [CurseForge][CRSFG:url] version will include .dll’s

# Removed

- duplicate patches (SSPX.cfg)

# GUI Icons

- customized app icon with permission from taniwha! thank you!

# Localization

- added Chinese [zh-cn.cfg]

# CurseForge/Overwolf

- corrected archive packaging for installer

# Backend
- folder maintenance
- moved Patches --> Compatibility
- update automation to latest version
- convert _release.json to schema 1.0.2.1

# Kerbal Changelog

- due to concerns about bloating the game and module manager .cache files
- therefor changelogs might be affecting game load times
- renamed to [Changelog.kcl] and updates have been suspended.

# [ScienceLabs.cfg] v1.0.2.1

- add FullyEquipped = true (might increase productivity factor)
- Lint and maintenance pass

# [ExperienceTraits.cfg] v1.0.0.1

- adjust patch [EXPERIENCE_TRAIT[Pilot]] in order to reduce log spam
- adjust patch [EXPERIENCE_TRAIT[Engineer]] in order to reduce log spam

# [Launchclamps.cfg] v1.0.2.0

- the clampBurgler has been caught and locked away.

# [Tanks.cfg] v1.0.1.0

- append '-ore' to stock tanks
- adjusted :NEEDS so always will create / modify, even if a switcher add on is installed
- added tags:BEFORE[SimpleConstruction]
- remov tags:BEFORE[SimpleConstruction]
- adjust tags part of part creation - replacing ore with either metal or rocketparts
- adjust timing of patches to ensure proper execution
  
# [DockingPorts.cfg] v1.0.2.0

- [ELLauchpad]
  - PadName = $#../Title# (to help self label Pads)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELTarget]
  - remove [TargetTransform]
  - remove [SpawnHeightOffset]
  - %TargetName = $#../Title# (to help self label Targets)
  - adjusted [spawnOffset ] to help prevent clipping. NOTE: if rotate/offset gizmo's have been used this offset will not help. Feature Request has been submitted to taniwha.
- [ELWorkshop]
  - add UnManned Productivity = 0.25; 
  - add IgnoreCrewCapacity = true;

# [CrewedPods.cfg] v1.0.1.1

- add to none command/crewed parts: FullyEquipped = true (might increase productivity factor)

### Status

- Issues/Milestones
 - closes #10 - Create SC Icon
 - closes #17 - 4.0.99.1-prerelease
 - closes #13 - 1.1.2.99-prerelease - two week CurseForge
 - closes #19 - Localization - master
 - closes #21 - Localization - Chinese
 - closes #34 - Localization - German
 - closes #35 - Duplicate patches
 - closes #36 - Launchclamps
 - updates #36 - Spawn location
 - closes #43 - Version 
 - closes #44 - Legal MumboJumbo 
 - closes #45 - Update documentation  
 - closes #46 - Release 4.0.9.9.1-prerelease 
 - closes #47 - Social Media 
- Pull Requests
  - closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer 
  - closes # - [ImgBot] Optimize images - contributed by imgbot[bot]
- *** Possible future changes ***
  - #40 - Stock Recycler
  and more

- [ELWorkshop]
  - newly discovered KSPFields
  - bool FullyEquipped;
  - bool - IgnoreCrewCapacity = true;
  - float - ProductivityFactor = 1f;
  - float - UnmannedProductivity;
@settings settings bot removed this from the Stock Recycler milestone Feb 26, 2022
@settings settings bot removed the type: request label Feb 26, 2022
@AtomikkuSan
Copy link

what part? should it be an add module to or should it be a +PART (copy)?

Well, whatever happened to the disassembler?

@zer0Kerbal
Copy link
Owner Author

what part? should it be an add module to or should it be a +PART (copy)?

Well, whatever happened to the disassembler?

This mod as is with all Simple mods aims to not add any models or textures - but in order to do a recycler would need a new part (which is already added in Not So SimpleConstruction! (NSSC)) or to add a mesh to an existing part like a claw or cargo ramp - something I do not know how to do and do not have the time to learn. Also way to futzy for my patience tolerance.

Something that would allow you to click on a part and recycle metal or ore or rocketparts along with resource? that is part of the code part - the Launchpad.dll, which I have nothing to do with, except using it with permission.

@zer0Kerbal zer0Kerbal added issue: model issue type issue: texture issue type issue: config issue type issue: external issue originates from external sources work: complex The situation is complex, emergent practices used. state: won't fix No action will be taken at this time labels May 4, 2022
@AtomikkuSan
Copy link

So there isn't some code in the Launchpad.ddl that allows you to disassembled a docked module?

@zer0Kerbal
Copy link
Owner Author

So there isn't some code in the Launchpad.ddl that allows you to disassembled a docked module?

there is - at least should be - I've just not the time nor the inclination to go poke into other people code.

@zer0Kerbal
Copy link
Owner Author

quoting @taniwha:

The recycler code relies on a trigger collider on the part, so a stock part would have to be MODEL{} hacked to have such a collider. This would be done by creating a .mu file with just the collider, and an MM patch to put the appropriate MODEL{} magic into the part's cfg (the MODEL node would reference the stock part's .mu and the collider's .mu).

@zer0Kerbal zer0Kerbal added this to the 4.0.99.10 milestone Jul 8, 2022
@zer0Kerbal zer0Kerbal mentioned this issue Jul 21, 2022
Merged
@zer0Kerbal zer0Kerbal mentioned this issue Aug 8, 2022
Merged
@zer0Kerbal zer0Kerbal pinned this issue Aug 8, 2022
@zer0Kerbal zer0Kerbal mentioned this issue Sep 30, 2022
Merged
@zer0Kerbal
Copy link
Owner Author

zer0Kerbal commented Oct 1, 2022 •
edited
Loading

discuss here: #145

Experimental

  • NEW:

    • Added recycler to "The Klaw" [GrapplingDevice]
    • updates Stock Recycler #40 - Stock Recycler
    • adds a seperate mesh for the recycler
    • mesh needs some placement and size tweaks

First Version: SimpleConstruction-Experimental-v1.0.0.0.zip

@zer0Kerbal zer0Kerbal mentioned this issue Jan 10, 2023
Merged
@zer0Kerbal zer0Kerbal unpinned this issue Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
issue: config issue type issue: external issue originates from external sources issue: model issue type issue: texture issue type state: won't fix No action will be taken at this time work: complex The situation is complex, emergent practices used.
Projects
None yet
Milestone
4.0.99.20-prerelease
Development

Successfully merging a pull request may close this issue.

Version 4.0.99.33-prerelease <eengie B9 no fast builds> edition zer0Kerbal/SimpleConstruction
2 participants
@zer0Kerbal @AtomikkuSan