-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zend XML - fix version comparison operator #26
Conversation
(cherry picked from commit 8f8e4f5)
@partikus: describe the problem you are solving. i.e why should maintainers accept this change? also as this is repo of all components, what component this affects? (update title). |
@glensc I hope the PR's initial comment answering your question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @partikus !
Unrelated to this change, php 5.3 travis build started to fail, https://travis-ci.com/github/zf1s/zf1/jobs/392057787
🤔 |
Last successful build https://travis-ci.com/github/zf1s/zf1/jobs/375326855 used
Now it's using
It could be that there is a bug in composer itself.. I don't think they stopped supporting php 5.3 just yet in v1 |
I just checked the other variant of this, and it's broken there too: |
"Peer fingerprint did not match" sounds like a temporary error. Try retrying, try clearing Travis caches. If that doesn't work, report to the composer project, or Travis support. |
Today it worked 🎉 |
This PR fixes an invalid operator. gte is not supported.
If the third optional operator argument is specified, test for a particular relationship. The possible operators are: <, lt, <=, le, >, gt, >=, ge, ==, =, eq, !=, <>, ne respectively.
https://www.php.net/manual/en/function.version-compare.php