PHP 8.0 porting status

[glensc]

List of documented backward-incompatible changes:

• https://www.php.net/manual/en/migration80.incompatible.php

Tasks

• PHP 8.0 compatibility patch: PHP8.0 compatibility patch #32
  • Fix a bug in Zend_Date for PHP 8.0 Fix a bug in Zend_Date for PHP 8.0 #62
  • Missing default values caused errorHandlerIgnore to fail under PHP 8.0, Missing default values caused errorHandlerIgnore to fail under PHP 8.0 #63
  • Guard file_exists call to prevent fatal error, Guard file_exists call to prevent fatal error #64
  • Remove libxml deprecations for php 8.0, Remove libxml deprecations for php 8.0 #65
  • Do not pass &$parts as reference to resolvePharParentPath, Do not pass &$parts as reference to resolvePharParentPath #67
  • Ensure non-negative values for bcmath, Ensure non-negative values for bcmath #68
  • Add support for gd resource type change in php 8.0, Add support for gd resource type change in php 8.0 #69
  • Add guard on fclose in Zend_Mail_Storage_Mbox, Add guard on fclose in Zend_Mail_Storage_Mbox #70
  • Implement T_NAME_QUALIFIED token in ClassFileLocation for php 8.0, Implement T_NAME_QUALIFIED token in ClassFileLocation for php 8.0 #71
  • Remove openssl deprecation for php 8.0, Remove openssl deprecation for php 8.0 #73
  • php 8.0: Change call in ClassMapAutoloader to preserve original behaviour, php 8.0: Change call in ClassMapAutoloader to preserve original behaviour #74
  • Make Zend_Validate_Date work as expected under PHP 8.0, Make Zend_Validate_Date work as expected under PHP 8.0 #75
  • Fixed reflection deprecations for php 8.0, Fixed reflection deprecations for php 8.0 #76
  • Small fixes for tests in favor of PHP 8.0 compat, Small fixes for tests in favor of PHP 8.0 compat #77
  • Remove default values from method signatures, Remove default values from method signatures #78
  • Fix vsprintf TypeError for php 8.0, Fix vsprintf TypeError for php 8.0 #79
  • Enforce types for PHP 8.0, Enforce types for PHP 8.0 #80
  • Fix Zend_Form_ElementTest, Fix Zend_Form_ElementTest #81
  • Fix iterators usage, Fix iterators usage #82
  • DB2 constants are missing when setting up db factory, DB2 constants are missing when setting up db factory #83
  • Catch ValueError on PHP 8.0 for Pdo Statement Catch ValueError on PHP 8.0 for Pdo Statement #85
• Remove usage of $php_errormsg: php 8: The track_errors ini directive has been removed #35, Remove usage of $php_errormsg #42
• version_compare does not support gte: PHP 8.0 porting status #51 (comment), Zend XML - fix version comparison operator #26
• iconv_substr behaves differently under PHP 8: iconv_substr behaves differently under PHP8 #31
• Zend_Log: catch TypeError/ValueError for PHP 8.0, Zend_Log: catch TypeError/ValueError for PHP 8.0 #88
• Fix error handler for PHP8 usage [zend-session] Fix error handler for PHP8 usage #99
• Fix Zend_Db issues with php8 Fix Zend_Db issues with php8 #106
• php8 Zend_Log compatibility fixes php8 Zend_Log compatibility fixes #107
• [zend-paginator] prevent fatal error on php8 [zend-paginator] prevent fatal error on php8 #109
• [zend-queue] prevent TypeError on md5 of non-string message [zend-queue] prevent TypeError on md5 of non-string message #110
• [zend-loader] refactor broken resolvePharParentPath static method [zend-loader] refactor broken resolvePharParentPath static method  #111

[glensc]

PHP 8.x version_compare error

• PHP 8.x version_compare error Shardj/zf1-future#128

Either one of these happens:

1. we can pick their patch
2. (if I have time), I could do a mass replace of all code and use PHP_VERSION_ID instead.
3. somebody else does the "2."

EDIT: this is fixed in #26 already (1.13.4 release)

[glensc]

@onlime you may have a better chance with this fork. it's in progress as well, but at least patches have been made, not yet reviewed and merged.

[onlime]

@onlime you may have a better chance with this fork. it's in progress as well, but at least patches have been made, not yet reviewed and merged.

Thanks @glensc - I know about zf1s/zf1 but newer found a simple way to replace shardj/zf1-future in my two use cases:

• A large project which uses more than a third of all zf1 components: Would I need to specify all single components from zf1s/zf1 as separate Composer requirements?
• ZF1 in a common path for all of my customers on a shared host: Customers require that library dir directly, without using Composer. Cannot tell them to change all their (legacy) projects.

So my question is: How to compile all zf1s/zf1 components into a single library dir? Or how to require all components in Composer? (composer require zf1s/zend-* is not supported)

[glensc]

@onlime you can install the monorepo as well:

composer require zf1s/zf1

or you can just download the zip and unpack it:

• https://github.com/zf1s/zf1/releases/latest

however, you still need to use composer autoloader, as the require_once calls embedded in the code have been removed. you can use your own autoloader if you wish, but composer autoloader just works.

for your shared customers you could:

1. create shared composer project: composer create-project zf1s/zf1 /var/www/zf1 (or use git clone, zip download and unpack)
2. tell customers to include one line in their codebase: require_once '/var/www/zf1/vendor/autoload.php';

if you still want to list each component separately, you can start with this list:

• https://github.com/zf1s/zf1/blob/1.13.4/composer.json#L114-L202

however, it's probably better just grep Zend_ from the codebase and deduct the package name.

EDIT: this needs to be fixed first for the composer solution to work: #57

[onlime]

@glensc Thanks for your detailed instructions! This all makes sense and would be very easy to implement.

But concerning my shared customers, it's impossible to communicate any change here. I definitely cannot tell them to migrate their projects to Composer autoloading, even if it would just be a matter of swapping out a single require_once line. I guess most customers that still run their projects on ZF1 have either an outdated deployment process or are just no longer responsible for the project. I cannot introduce any breaking change here. But on the other hand, I can easily recommend them to just fire up composer require zf1s/zf1 (after a fixed #57) if they are no longer happy with the shared zf1-future code base. I let it be their choice and I don't want to introduce any noise here.

[glensc]

@falkenhawk perhaps make a release with the merged code. it's not worse as it is for older PHP versions, and it's definitely something for PHP 8.0.

I don't think I'll work with any of the unfinished pull requests any time soon, and so appears to be for Megatherium.

[falkenhawk]

@glensc thank you for your hard work on this so far. Okay I will cut a release in the following days, if time allows. I will also either try myself or ask around if someone could continue working on the unfinished PRs.

[glensc]

@falkenhawk how about that release?

EDIT: I've started PR, jump in and advice what else is needed:

• Release 1.13.5 #93

[falkenhawk]

Release 1.14.0 is out 🎉