php 8.0: Change call in ClassMapAutoloader to preserve original behaviour #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP8 the third param of array_walk ($userdata) is automatically passed by value thus calling a function that expects pass by reference as the third param is not possible. Simply changing the array_walk to a foreach loop allows us to fulfill the pass by reference signature.
glensc
changed the title
glensc
changed the title
|
This branch commit was moved into #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP8 the third param of array_walk ($userdata) is automatically
passed by value thus calling a function that expects pass by reference
as the third param is not possible.
Simply changing the array_walk to a foreach loop allows us to fulfill
the pass by reference signature.
Extracted changes made by @Megatherium from #32