Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iterators usage #82

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 15, 2021

Made the handling of iterators in Zend_Controller_Action_HelperBroker_PriorityStackTest compatible with all versions.

From #32 (comment):

@falkenhawk on 3 Dec 2020 Member
does php8 throw on calling current() / next() on an iterator?

@Megatherium Megatherium on 3 Dec 2020 Author
It returns false and thus get_class throws a TypeError

Extracted out of #77 which was @Megatherium changes from #32

Made the handling of iterators in
Zend_Controller_Action_HelperBroker_PriorityStackTest compatible with
all versions

Signed-off-by: Alexander Wozniak <wozniak@oktopos.com>
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@glensc
Copy link
Contributor Author

glensc commented Mar 15, 2021

sorry, I do not have context of what was the problem, maybe it was discussed in #32

@falkenhawk
Copy link
Member

falkenhawk commented Mar 15, 2021

sorry, I do not have context of what was the problem, maybe it was discussed in #32

must be this #32 (comment)

@glensc
Copy link
Contributor Author

glensc commented Mar 15, 2021

@falkenhawk updated MR body

@falkenhawk falkenhawk merged commit 1cfdc03 into zf1s:master Mar 15, 2021
@glensc glensc mentioned this pull request Mar 16, 2021
32 tasks
@glensc glensc mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants