Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportedComputeTypes for List VM Sizes #22

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

ac923
Copy link

@ac923 ac923 commented Jul 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      This is a bug fix for adding the property supportedComputeTypes to the List VM Sizes API. This property was added in the 2020-08-01 version but was not copied over to the later api versions. This PR will update version 2021-04-01 and 2021-01-01 with the new property.
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. N/A
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet. N/A
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@zhaomuzhi zhaomuzhi merged commit 839b2fe into zhaomuzhi:newVersion20210701 Jul 9, 2021
zhaomuzhi pushed a commit that referenced this pull request Jul 9, 2021
* ACR Admin swagger spec changes

* Release/larisab (#1)

* Add swagger spec for acr setup.

* Add swagger spec for acr setup - fixed jsons.

* Add swagger spec for acr setup - address feedback to convert get status to post.

* Add swagger spec for acr setup - fixed typo.

* Add swagger spec for acr setup - added setup specs to readme.

* Add swagger spec for acr setup - fixed checkSetup definitions.

* Add swagger spec for acr setup - addressed comments.

* Add swagger spec for acr setup - addressed ARM feedback.

* Add swagger spec for acr setup - added proper input-files n readme.

* Add swagger spec for acr setup - fixed inavalid scheme.

* Add swagger spec for acr setup - fixed inavalid method Post instaed of Get.

Co-authored-by: Larysa Borodina <larisab@microsoft.com>

* Update API changes (#2)

* Update API changes

* Add delete call implementation

* update examples

* Fix swagger validation errors. (#3)

* Fix swagger validation errors - 2-nd. (#4)

* Fix model validation fix

* Fix swagger validation errors - 3d. (#5)

* Fix swagger validation errors - 4th. (#6)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Release/acrchanges (#8)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Release/acrchanges (#9)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Release/larisab (#11)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 12th.

* Release/acrchanges (#12)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Release/acrchanges (#13)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Release/acrchanges (#14)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Release/acrchanges (#15)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Release/acrchanges (#16)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Release/acrchanges (#17)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Release/acrchanges (#18)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Release/acrchanges (#19)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Release/acrchanges (#20)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Release/acrchanges (#21)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Release/acrchanges (#22)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Release/acrchanges (#23)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Release/acrchanges (#24)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Release/acrchanges (#25)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Release/acrchanges (#26)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Use v2 common resource types for parameters also.

* Release/acrchanges (#27)

* Fix swagger validation errors - 4th.

* Fix swagger validation errors - 5th.

* Fix swagger validation errors - 6th.

* Fix swagger validation errors - 7th.

* Fix swagger validation errors - 13th.

* Fix swagger validation errors - 14th.

* Fix swagger validation errors - 15th.

* Fix swagger validation errors - 16th.

* Fix swagger validation errors - 17th.

* Fix swagger validation errors - 18th.

* Fix swagger validation errors - 19th.

* Fix swagger validation errors - 20th.

* Fix swagger validation errors - 21th.

* Fix swagger validation errors - 21st.

* Fix swagger validation errors - 22st.

* Fix swagger validation errors - 23st.

* Fix swagger validation errors - 24st.

* Fix swagger validation errors - 25th.

* Fix swagger validation errors - 26th

* Fix swagger validation errors - 27th

* Fix swagger validation errors - 28th

* Fix swagger validation errors - 29th

* Fix swagger validation errors - 30th

* Fix swagger validation errors - 31th

* Fix swagger specs, address comments and naming bug - 32th

* Fix swagger specs, address comments and naming bug - 33th

* Fix swagger specs - 34th

* Test cmdlet name creation with recommended operation id for quota

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Test cmdlet name creation with recommended operation id

* Use v2 common resource types.

* Use v2 common resource types for parameters also.

* Use v2 common resource types for parameters also. - fixed the readme to remove unneeded file

Co-authored-by: Rohit Jaini <rjaini@microsoft.com>
Co-authored-by: larysaborodina <larysaborodina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants