[docker-lldp] Fix lldpcli issue when description has special characters #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 12, 2020
* src/sonic-telemetry fa8d498...3bd7ca3 (4): > Update gnmi deps (zhenggen-xu#40) > [testdata] Update SFP keys to align with new standard (zhenggen-xu#39) > Fixed the parameters for subscribe APIs (zhenggen-xu#38) > Azure ro mode (zhenggen-xu#34) * src/sonic-mgmt-common 444aa9a...cc01ce4 (4): > Make gnmi dep version the same as in telemetry repo (zhenggen-xu#17) > Cleanup translib and cvl go test cases (zhenggen-xu#13) > Package update and enhancements/fixes in YGOT, and Request Binder (zhenggen-xu#12) > Translib phase I changes (zhenggen-xu#11) Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch
li-pingmao
pushed a commit
to li-pingmao/sonic-buildimage
that referenced
this pull request
Feb 23, 2022
457e94d51 [macsec_linux]: Fixbug cannot dump the PN due to type error (zhenggen-xu#42) f7c073323 Disable P2P module (zhenggen-xu#41) 7b3b777e2 [ci]: use native arm64 and armhf build pool (zhenggen-xu#40) d4e91d66c [sonic_operator]: Increase wait timeout (zhenggen-xu#39) 43611ef88e [sonic_operators]: Add log in sonic operators (zhenggen-xu#43) Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docker-lldp] Fix lldpcli issue when description has special characters
Signed-off-by: Zhenggen Xu zxu@linkedin.com
This should be back-ported to 201911 and 201811 branch.
- What I did
Fix lldpcli issue when description has special characters
- How I did it
Quote the description field.
- How to verify it
Before the fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2
bash: sonic1: command not found
bash: Eth1/3/2: No such file or directory
After fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2'
run successfully.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)