Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-yang-models]: Add default values in leaf-lists of ports in son… #77

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

praveen-li
Copy link
Collaborator

…ic-acl and sonic-portchannel.

Changes:
-- Add default values in leaf-lists of ports in sonic-acl
-- Add default values in leaf-lists of ports in sonic-portchannel
-- Remove members from sonic-vlan VLAN table. Note this will force Network Operations
team to change the config.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com

- What I did
Changes:
-- Add default values in leaf-lists of ports in sonic-acl
-- Add default values in leaf-lists of ports in sonic-portchannel
-- Remove members from sonic-vlan VLAN table. Note this will force Network Operations
team to change the config.

- How I did it
Added String Type and DEfault value in YANG.

- How to verify it

Default value leaf-list testing:


============================== 1 tests deselected ==============================
=================== 1 passed, 1 deselected in 93.69 seconds ====================
svc-lnos-user@server10:/home/svc-lnos-user/praveen/sonic-buildimage/src/sonic-swss/tests$ cat test_port_dpb_system.py | grep -A 4 -B 4 Uncomment

        # Verify port is removed from ACL table
        self.dvs_acl.verify_acl_table_count(1)

        #TBD: Uncomment this, or explain why Ethernet0 is being added back to ACL table
        # Also, string "None" is being added as port to ACL port list after the breakout
        self.dvs_acl.verify_acl_group_num(0)

        # Verify child ports are created.
svc-lnos-user@server10:/home/svc-lnos-user/praveen/sonic-buildimage/src/sonic-swss/tests$ sudo pytest --dvsname=vs-jk test_port_dpb_system.py -k test_port_breakout_with_acl --junitxml=report.xml | tee out
============================= test session starts ==============================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.6.0, pluggy-0.6.0
rootdir: /home/svc-lnos-user/praveen/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 2 items

test_port_dpb_system.py .                                                [100%]

 generated xml file: /home/svc-lnos-user/praveen/sonic-buildimage/src/sonic-swss/tests/report.xml
============================== 1 tests deselected ==============================
=================== 1 passed, 1 deselected in 94.25 seconds ====================

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…ic-acl and sonic-portchannel.

Changes:
-- Add default values in leaf-lists of ports in sonic-acl
-- Add default values in leaf-lists of ports in sonic-portchannel
-- Remove members from sonic-vlan VLAN table. Note this will force Network Operations
   team to change the config.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@zhenggen-xu
Copy link
Owner

@praveen-li Can you please add the VLAN table changes to DPB wiki since it require operational changes?

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@vasant17 vasant17 merged commit f535f5e into zhenggen-xu:sonic-cfg-mgmt Jun 12, 2020
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 12, 2020
* src/sonic-snmpagent 89b7b2c...c702a57 (7):
  > Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#133)" (sonic-net#151)
  > Update transceiver info DB key names (sonic-net#146)
  > Fix LGTM reported alert of PR#141 (sonic-net#142)
  > [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (sonic-net#141)
  > [Namespace]: Fix SNMP AgentX  socket connection timeout when using Namespace.get_all()  (sonic-net#140)
  > [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#133)
  > Fix undefined variable and warning message (sonic-net#134)

* src/sonic-py-swsssdk a83366e...2df4f40 (3):
  > Allowing TCP connections with namespace as well. (zhenggen-xu#81)
  > [port_util] add get_rif_port_map, get_vlan_interface_oid_map (zhenggen-xu#78)
  > Updates to the namespace API's for test_moduleLoad.py (zhenggen-xu#77)

Note that sonic-snmpagent submodule update is dependent upon sonic-py-swsssdk update, so updating both submodules in this PR.
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Sep 15, 2020
Update the patform daemons with new commits 

commit e9628b6
    Merge pull request zhenggen-xu#64 from judyjoseph/multi_asic_ledd_xcvr
    * platform daemon (Xcvrd, Ledd) changes for multi asic platform
      * Updates in ledd daemon to use namespaces and get the namespace from selector object.
      * Updates to xcvrd daemon to use the asic_id in talking to the right DB.
      * Updated based on new sonic-py-common API's
      * Invoke initializeGlobalConfig() in the SfpUpdate/DomInfoUpdate processes as well.

commit 415b8c4
    [thermalctld] Optimize the thermal policy loop to make it execute every 60 seconds (zhenggen-xu#77)
    
commit 3d1f319
    Update FAN_INFO in psud to avoid inconsistant output of show platform psud and show platform fan (zhenggen-xu#81)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Apr 27, 2021
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75)
Mar 11 Update route api to specify limitation (zhenggen-xu#77)
Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Jun 23, 2021
[Submodule update] sonic-telemetry

[multi-asic] Added Support  for multi-asic for telemetry/gnmi server (zhenggen-xu#77)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Jul 28, 2021
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75)
Mar 11 Update route api to specify limitation (zhenggen-xu#77)
Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 9, 2022
[sonic-linkmgrd][master] submodule updates

d744bfb Longxiang Lyu Wed May 25 08:40:42 2022 +0800 Support switch between using wellknown mac or server mac addr (zhenggen-xu#73)
684e989 Jing Zhang Wed May 18 09:59:02 2022 -0700 Avoid switching active when LinkState == Down (zhenggen-xu#77)
e4aa4fd Longxiang Lyu Tue May 17 09:13:23 2022 +0800 [Makefile] Remove redundant optimization options (zhenggen-xu#75)
4ec7505 Jing Zhang Thu May 12 08:19:20 2022 -0700 [ci]: uplift diff coverage threshold to 80% (zhenggen-xu#71)

sign-off: Jing Zhang zhangjing@microsoft.com
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Dec 23, 2022
[sonic-linkmgrd][202012] submodule updates

489cf3 Jing Zhang Wed May 18 09:59:02 2022 -0700 Avoid switching active when LinkState == Down (zhenggen-xu#77)
a6c9713 Jing Zhang Tue May 24 11:03:54 2022 -0700 [202012] Add option to enable or disable default route related feature (zhenggen-xu#72)
dbb607d Jing Zhang Thu May 12 08:19:20 2022 -0700 [ci]: uplift diff coverage threshold to 80% (zhenggen-xu#71)

sign-off: Jing Zhang zhangjing@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants