Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory a… #80

Merged
merged 2 commits into from
Jun 29, 2020
Merged

[sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory a… #80

merged 2 commits into from
Jun 29, 2020

Conversation

praveen-li
Copy link
Collaborator

…nd add default value of stage for sonic-acl.yang.

Changes:
-- Make type mandatory and add default value of stage.
-- Test case.
-- Support for Verification in data tree.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com

- What I did
Changes:
-- Make type mandatory and add default value of stage for sonic-acl.yang.
-- New Test case.
-- Support for Verification in data tree.

- How I did it
Get the data tree using ly.LYP_WD_ALL option, so that default fields are populated.

- How to verify it
built all relevant PKGs.

pchaudha@server05:/home/pchaudha/srcCode/dpb_repo$ ls -l target/python-wheels/
total 312
-rw-r--r-- 1 pchaudha pchaudha  45430 Jun 23 15:07 sonic_config_engine-1.0-py2-none-any.whl
-rw-r--r-- 1 pchaudha pchaudha   1849 Jun 23 15:15 sonic_config_engine-1.0-py2-none-any.whl-install.log
-rw-r--r-- 1 pchaudha pchaudha 172688 Jun 23 15:07 sonic_config_engine-1.0-py2-none-any.whl.log
-rw-r--r-- 1 pchaudha pchaudha  13426 Jun 23 15:04 sonic_yang_mgmt-1.0-py2-none-any.whl
-rw-r--r-- 1 pchaudha pchaudha    656 Jun 23 15:15 sonic_yang_mgmt-1.0-py2-none-any.whl-install.log
-rw-r--r-- 1 pchaudha pchaudha   4155 Jun 23 15:04 sonic_yang_mgmt-1.0-py2-none-any.whl.log
-rw-r--r-- 1 pchaudha pchaudha  13335 Jun 23 15:32 sonic_yang_models-1.0-py3-none-any.whl
-rw-r--r-- 1 pchaudha pchaudha    662 Jun 23 15:15 sonic_yang_models-1.0-py3-none-any.whl-install.log
-rw-r--r-- 1 pchaudha pchaudha  15327 Jun 23 15:32 sonic_yang_models-1.0-py3-none-any.whl.log
-rw-r--r-- 1 pchaudha pchaudha  13712 Jun 23 15:06 swsssdk-2.0.1-py2-none-any.whl
-rw-r--r-- 1 pchaudha pchaudha    865 Jun 23 15:15 swsssdk-2.0.1-py2-none-any.whl-install.log
-rw-r--r-- 1 pchaudha pchaudha   3625 Jun 23 15:06 swsssdk-2.0.1-py2-none-any.whl.log
pchaudha@server05:/home/pchaudha/srcCode/dpb_repo$ date
Tue Jun 23 15:40:45 PDT 2020
pchaudha@server05:/home/pchaudha/srcCode/dpb_repo$

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory a…
339e888 
…nd add default value of stage.

Changes:
-- Make type mandatory and add default value of stage.
-- Test case.
-- Support for Verification in data tree.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@praveen-li
Copy link
Collaborator Author

@vasant17 REview when possible.

@zhenggen-xu
Copy link
Owner

@praveen-li Can you add the test results in the build log to the PR?

[yang_model_tests/yangModelTesting.py]: Adding Description.
ee6f6d9 
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
RB=
G=lnos-reviewers
R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu
A=
@praveen-li praveen-li merged commit 0f85026 into zhenggen-xu:sonic-cfg-mgmt Jun 29, 2020
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 12, 2020
@jleveque
[sonic-platform-common][sonic-platform-daemons] Update submodules (so…
d272802 
…nic-net#5103)

* src/sonic-platform-common be1cc24...f3f3573 (3):
  > Remove sonic-config-engine dependency from setup.py (sonic-net#109)
  > Migrate from sonic-daemon-base package to sonic-py-common package (sonic-net#103)
  > [Cables] Add support for 'Extended Specification Compliance' for QSFP cables (sonic-net#108)
  > [sfputilbase.py] Add application_advertisement NA field to transceiver_info_dict for platform api 1.0 (sonic-net#104)

* src/sonic-platform-daemons 49d145c...8e0704e (1):
  > Proper fix for thermalctld using sonic-py-common (zhenggen-xu#80)
  > Fix thermalctld tests which were broken by the transition to sonic-py-common (zhenggen-xu#79)
  > Migrate from sonic-daemon-base package to sonic-py-common package (zhenggen-xu#74)
zhenggen-xu pushed a commit that referenced this pull request Aug 31, 2020
@abdosi
[Submodule update] sonic-platform-common with PR's
ca926f2 
[Chassis base] Add sfp error event definition #80
SFP(sff8472 attributes) transciever eeprom attribute support #74
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Oct 9, 2020
[sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory a… (
8bb9864 
zhenggen-xu#80)

* [sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory and add default value of stage.

Changes:
-- Make type mandatory and add default value of stage.
-- Test case.
-- Support for Verification in data tree.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
zhenggen-xu pushed a commit that referenced this pull request Dec 15, 2020
@nazariig
[submodule]: Advance sonic-platform-common. (sonic-net#4513)
2153cae 
Commits on Mar 20, 2020
SFP(sff8472 attributes) transciever eeprom attribute support. (#74) 9b1dea5

Commits on Mar 22, 2020
Detect an SFP adapter in a QSFP port, and instantiate an SFP object i… 116eeec

Commits on Apr 13, 2020
[component]: Introduce new firmware management API. 2632a59

Commits on Apr 16, 2020
[Chassis base] Add sfp error event definition (#80) f1f00ec

Commits on Apr 24, 2020
[component]: Update firmware management API. 777901f
[component]: Extend docstrings for firmware management API. b066ec7

Commits on Apr 30, 2020
[component]: Fix review comments. d96344e
Merge pull request #82 from nazariig/master-component-firmware-api 28c39c5 

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Apr 27, 2021
@sumukhatv
[submodule]: Update restapi (sonic-net#7213)
71afd4b 
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75)
Mar 11 Update route api to specify limitation (zhenggen-xu#77)
Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Jul 28, 2021
@sumukhatv @yxieca
[submodule]: Update restapi (sonic-net#7213)
915cb44 
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75)
Mar 11 Update route api to specify limitation (zhenggen-xu#77)
Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 9, 2022
@xumia
[Submodule]: Update submodule for sonic-telemetry (sonic-net#10124)
f34b5e6 
e56e9b4 Fix CVE-2021-3121 warning (sonic-net#96)
bf1be4f [ci]: Support code diff coverage threshold 50% (zhenggen-xu#94)
64e516c Ported Marvell armhf build on x86 for debian buster to use cross-compilation instead of qemu emulation (zhenggen-xu#80)
e426388 [ci]: Support azp code coverage (zhenggen-xu#87)
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Aug 9, 2022
@zjswhhh
[sonic-linkmgrd][master] Submodule Update (sonic-net#11035)
6b70b44 
[sonic-linkmgrd][master] Submodule Update

9c8a16e Jing Zhang Sun Jun 5 08:27:07 2022 -0700 Separate I2C mux state probing and gRPC forwarding state probing (zhenggen-xu#86)
491c4ee Longxiang Lyu Sun Jun 5 23:26:19 2022 +0800 Fix peer mux wait back off factor (zhenggen-xu#84)
a0b6b14 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (zhenggen-xu#23)" (zhenggen-xu#85)
3c2b546 Jing Zhang Tue May 31 10:14:42 2022 -0700 Add default route support to active-active state machine (zhenggen-xu#78)
6fa892e Longxiang Lyu Fri May 27 09:15:06 2022 +0800 Degrade LinkProberStateMachineBase virtual function logging level (zhenggen-xu#80)
7b695ca Longxiang Lyu Fri May 27 09:14:02 2022 +0800 Fix mux wait timer and peer mux wait timer (zhenggen-xu#81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasant17 vasant17 vasant17 approved these changes

@li-pingmao li-pingmao li-pingmao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praveen-li @zhenggen-xu @vasant17 @li-pingmao