Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.process: add option to support single quotes to ArgIteratorGeneral #10788

Merged
merged 1 commit into from
Feb 5, 2022
Merged

std.process: add option to support single quotes to ArgIteratorGeneral #10788

merged 1 commit into from
Feb 5, 2022

Conversation

Vexu
Copy link
Member

@Vexu Vexu commented Feb 4, 2022

Closes #10787

Not sure whether we should accept single quotes for windows, I'm guessing not?

@splhack
Copy link
Contributor

splhack commented Feb 4, 2022

verified this (on top of 64f7231) fixed #10787 🎉

andrewrk
andrewrk approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we should accept single quotes for windows, I'm guessing not?

I don't know the answer to this either, but your patch makes it as simple as toggling a flag, so it's progress either way!

@andrewrk andrewrk merged commit 7d04ab1 into ziglang:master Feb 5, 2022
@Vexu Vexu deleted the quotes branch February 5, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support single quotes in response files
3 participants
@Vexu @splhack @andrewrk