Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faiss hnsw: get rid of a debugging config option #875

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

alexanderguzhva
Copy link
Collaborator

Just a small cleanup

/kind improvement

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (3c46f4c) to head (4319625).
Report is 211 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #875       +/-   ##
=========================================
+ Coverage      0   77.66%   +77.66%     
=========================================
  Files         0       84       +84     
  Lines         0     6361     +6361     
=========================================
+ Hits          0     4940     +4940     
- Misses        0     1421     +1421     

see 84 files with indirect coverage changes

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline. This is for original HNSW impl removing for now
/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z liliu-z merged commit fe0fb15 into zilliztech:main Sep 30, 2024
11 of 12 checks passed
@liliu-z
Copy link
Collaborator

liliu-z commented Sep 30, 2024

Manually merged. Don't know why e2e and e2e-sse didn't get triggered.
@cydrain plz take a check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants