Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faiss hnsw: get rid of a debugging config option #875

Merged
merged 1 commit into from
Sep 30, 2024

faiss hnsw: get rid of a debugging config option

4319625
Select commit
Loading
Failed to load commit list.
Merged

faiss hnsw: get rid of a debugging config option #875

faiss hnsw: get rid of a debugging config option
4319625
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Sep 30, 2024 in 2s

4 rules match and 8 potential rules

⚠️ The pull request has been merged by @liliu-z

Rule: Add needs-dco label when DCO check failed (label)

  • -status-success=DCO
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

✅ Rule: Add dco-passed label when DCO check passed (label)

  • status-success=DCO
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

Rule: Blocking PR if missing a related issue or PR doesn't have kind/improvement label (comment, label)

  • -label=kind/improvement
  • -title~=\[automated\]
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$
  • any of:
    • all of:
      • -body~=\#[0-9]{1,6}(\s+|$)
      • -body~=https://github.com/zilliztech/knowhere/issues/[0-9]{1,6}(\s+|$)
    • all of:
      • -label=kind/bug
      • -label=kind/enhancement
      • -label=kind/feature

✅ Rule: Dismiss block label if related issue be added into PR (label)

  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$
  • any of:
    • label=kind/improvement
    • all of:
      • any of:
        • label=kind/bug
        • label=kind/enhancement
        • label=kind/feature
      • any of:
        • body~=\#[0-9]{1,6}(\s+|$)
        • body~=https://github.com/zilliztech/knowhere/issues/[0-9]{1,6}(\s+|$)

Rule: Blocking PR if have multiple 'kind' type labels (comment, label)

  • any of:
    • all of:
      • any of:
        • label=kind/bug
        • label=kind/enhancement
        • label=kind/feature
      • label=kind/improvement
    • all of:
      • label=kind/enhancement
      • any of:
        • label=kind/improvement
        • label=kind/bug
        • label=kind/feature
    • all of:
      • label=kind/feature
      • any of:
        • label=kind/improvement
        • label=kind/bug
        • label=kind/enhancement
    • all of:
      • label=kind/bug
      • any of:
        • label=kind/improvement
        • label=kind/enhancement
        • label=kind/feature
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

✅ Rule: Dismiss block PR if have not multiple 'kind' type labels (label)

  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$
  • any of:
    • all of:
      • -label=kind/bug
      • -label=kind/enhancement
      • -label=kind/feature
      • label=kind/improvement
    • all of:
      • -label=kind/improvement
      • label=kind/enhancement
      • -label=kind/bug
      • -label=kind/feature
    • all of:
      • -label=kind/improvement
      • label=kind/feature
      • -label=kind/bug
      • -label=kind/enhancement
    • all of:
      • -label=kind/improvement
      • label=kind/bug
      • -label=kind/enhancement
      • -label=kind/feature
    • all of:
      • -label=kind/improvement
      • -label=kind/bug
      • -label=kind/enhancement
      • -label=kind/feature

Rule: Test passed for code changed for main (label)

  • status-success=e2e
  • status-success=e2e-gpu
  • status-success=e2e-sse
  • status-success=ut-gpu
  • status-success=analyzer
  • status-success=e2e(arm)
  • status-success=pre-commit
  • status-success=python3 wheel
  • status-success=ut on ubuntu-22.04
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for cpu code changed only for main (label)

  • status-success=e2e
  • status-success=e2e-sse
  • -files~=^(?=src/index/ivf_raft/)
  • files~=^(?=.*((\.(h|cpp)|CMakeLists.txt))).*$
  • status-success=analyzer
  • status-success=e2e(arm)
  • status-success=pre-commit
  • status-success=python3 wheel
  • status-success=ut on ubuntu-22.04
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for non c++ or go code changed for main (label)

  • -files~=^(?=.*((\.(h|cpp)|CMakeLists.txt))).*$
  • status-success=e2e
  • status-success=e2e-sse
  • status-success=analyzer
  • status-success=e2e(arm)
  • status-success=pre-commit
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

Rule: Test passed for title skip e2e (label)

  • -files~=^(?=.*((\.(h|cpp)|CMakeLists.txt))).*$
  • title~=\[skip e2e\]
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$

✅ Rule: Remove ci-passed label when ut failed for main (label)

  • files~=^(?=.*((\.(h|cpp)|CMakeLists.txt))).*$
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success!=e2e
    • status-success!=e2e-sse
    • status-success!=analyzer
    • status-success!=e2e(arm)
    • status-success!=pre-commit
    • status-success!=python3 wheel
    • status-success!=ut on ubuntu-22.04

Rule: Remove ci-passed label when gpu ut failed for main (label)

  • files~=^(?=src/index/ivf_raft/)
  • files~=^(?=.*((\.(h|cpp)|CMakeLists.txt))).*$
  • any of:
    • base=main
    • base~=^2(\.\d+){1,2}$
  • any of:
    • status-success!=e2e
    • status-success!=e2e-gpu
    • status-success!=e2e-sse
    • status-success!=ut-gpu
    • status-success!=analyzer
    • status-success!=e2e(arm)
    • status-success!=pre-commit
    • status-success!=python3 wheel
    • status-success!=ut on ubuntu-22.04

💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!


2 not applicable rules

Rule: Add comment when jenkins job failed (comment)

  • check-failure=e2e
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$

Rule: Add comment when e2e-sse job failed (comment)

  • check-failure=e2e-sse
  • any of:
    • base=master
    • base~=^2(\.\d+){1,2}$
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com