Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace u128 mul with u64 muls for wasm target #15

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Replace u128 mul with u64 muls for wasm target #15

merged 1 commit into from
Sep 15, 2023

Conversation

AllFi
Copy link

@AllFi AllFi commented Jul 12, 2023 •
edited
Loading

The reasoning behind this PR can be found in the following issue.

@AllFi AllFi mentioned this pull request Jul 13, 2023
Open
EvgenKor
EvgenKor approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@EvgenKor EvgenKor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllFi AllFi mentioned this pull request Jul 12, 2023
Open
@r0wdy1 r0wdy1 merged commit cae963e into master Sep 15, 2023
@EvgenKor EvgenKor deleted the optimization/wasm_mul_64 branch February 2, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@lok52 lok52 lok52 approved these changes

@EvgenKor EvgenKor EvgenKor approved these changes

@akolotov akolotov Awaiting requested review from akolotov

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllFi @EvgenKor @lok52 @k1rill-fedoseev @r0wdy1