Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace u128 mul with u64 muls for wasm target #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace u128 mul with u64 muls for wasm target #1

wants to merge 2 commits into from

Conversation

AllFi
Copy link
Collaborator

@AllFi AllFi commented Jun 27, 2023 •
edited
Loading

It looks like 4 u64 multiplications work faster than one u128 in wasm.

  • i7-10750H: Proving time in wasm was reduced from ~15 s to 13 s (~13%)
  • iPhone 11: Proving time in wasm was reduced from ~35.5 s to 31 s (~13%)

This PR is similar to zkBob/fawkes-crypto#15 but optimizes proving. We need to update phase2-bn254 to use this crate instead of ff_ce.

lok52
lok52 reviewed Aug 16, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
@AllFi AllFi mentioned this pull request Aug 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@r0wdy1 r0wdy1 r0wdy1 approved these changes

@lok52 lok52 lok52 approved these changes

@EvgenKor EvgenKor EvgenKor approved these changes

@akolotov akolotov Awaiting requested review from akolotov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllFi @EvgenKor @lok52 @k1rill-fedoseev @r0wdy1