forked from zeropoolnetwork/libzeropool-rs
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/partial tree #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding leafs and commitments along with siblings
EvgenKor
requested review from
AllFi,
akolotov,
lok52,
k1rill-fedoseev and
r0wdy1
December 9, 2022 10:12
AllFi
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine in zkbob-console. The changes look good to me.
pub fn wipe(&mut self) { | ||
let mut wipe_batch = self.db.transaction(); | ||
|
||
// ???: It works fine in the local tests, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lok52
reviewed
Dec 13, 2022
lok52
reviewed
Dec 13, 2022
r0wdy1
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for partial tree sync by a client (with specified index), rollbacking, wiping and client self-healing:
getLeftSiblings
method inlibzkbob_rs::merkle
)get_root_at
method inlibzkbob_rs::merkle
)add_leafs_commitments_and_siblings
method inlibzkbob_rs::merkle
)rollback
method inlibzkbob_rs::merkle
)rollback
method inlibzkbob_rs::client::state
)libzkbob-rs-node
to support siblings, stable indexes and wipe methodslibzkbob-rs-wasm
to support all integrated methods on the client library sideThis branch can be tested along zkbob-client-js library and zkbob-console tool with associated branches