-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/partial tree #66
Conversation
Build with Actions was failed due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me but we'll need to merge it carefully with #65.
# Conflicts: # package.json # src/client.ts # src/index.ts # src/utils.ts # src/worker.ts # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zkBob/zeropool-relayer#113 has been merged. This PR can be tested now together with the new relayer. @EvgenKor could you post here results of the testing so we can merge the PR. Thanks! |
Local tests have passed successfully. Few issues were found and fixed. Library is ready to publish now. |
This merge contains the following set of changes: - Fix issue which prevents tracking history records for simple deposit via approve(#59) - Introduction of simple stats collecting(#60) - Introduction of cold storage for pool transactions (#64) - Add iOS/Safari support(#65) - Introduction of getting partial tree (#66)
Supporting for partial tree sync, state rollbacking and wiping, self-healing approach to restore corrupted state
birthindex
optional parameter inClientConfig
(which is used inZkBobClient
initialization). If it was set during init process, the state will sync from the specified index (need relayer support for siblings). Ifbirthindex < 0
- the library will convert it to the actual treenext_index - 128
(new account case)ZkBobClient::{getLocalState, getPoolState}
ZkBobClient::{getLeftSiblings, getFirstIndex}
- for testing purposes on the console toolZkBobClient::{rollbackState, cleanState}
- to support self-healingbirthindex
was specified. Partial tree sync conditions:/siblings?index=...
method, format was discussed with @LyzeOfKiel )next_index
value and last verified index. In case of equality - skip the checksnext_index
as last verified index and finish check routinebirthindex
in the synchronization processDepends on zkBob/libzkbob-rs#33 and zkBob/zeropool-relayer#113
The library can be tested along libzkbob-rs library and zkbob-console tool with associated branches.