forked from zeropoolnetwork/zeropool-relayer
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/request logs #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider to reduce the level for the http data to debug as so it is possible to filter it by setting |
Updates:
Now, log looks like this:
|
r0wdy1
approved these changes
Jan 9, 2023
akolotov
requested changes
Jan 10, 2023
akolotov
requested changes
Jan 10, 2023
akolotov
requested changes
Jan 10, 2023
akolotov
approved these changes
Jan 10, 2023
akolotov
added a commit
that referenced
this pull request
Jan 30, 2023
This merge contains the following set of changes: - Add debug log for RPC request errors (#131) - Add internal account validation (#135) - Add counter exceeded check for re-sent iterations (#138) - Improvement of logging requests to relayer (#140) - Fix failed contract calls (#145) - Add missed log (#149) - Add poolId validation (#154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
RELAYER_LOG_IGNORE_ROUTES
env, e.g./fee /params/hash/tx
. Also, I removed some common headers from requests to not flood the logs. Example request log:Closes #67
This PR should be considered as a draft, so any suggestions about logs format are welcome.