Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed contract calls #145

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix failed contract calls #145

merged 1 commit into from
Jan 17, 2023

Conversation

lok52
Copy link
Collaborator

@lok52 lok52 commented Jan 12, 2023

Changes:

  • Add contract call retry functionality in most critical places. But, there a few questions for discussion. How many times should we retry failed calls? Which interval between retries to choose? For now, 2 retries with 500ms interval is set.
    Closes Retry failed contract calls #144
  • Improve error handling. Now, in case of unrecoverable error there will be no pure stack traces in logs, instead it will be wrapped in a json logger message. Also, in such cases server will return code 500 with plain text Internal server error, instead of HTML template with the same message.

@akolotov akolotov merged commit 8126b98 into devel Jan 17, 2023
@akolotov akolotov deleted the fix/retry-contract-call branch January 17, 2023 13:53
@akolotov akolotov mentioned this pull request Jan 17, 2023
Merged
akolotov added a commit that referenced this pull request Jan 17, 2023
@akolotov
Merge the devel branch into the main branch, v3.1.0
43aa836 
This merge contains the following set of changes:
  - Add debug log for RPC request errors (#131)
  - Add internal account validation (#135)
  - Add counter exceeded check for re-sent iterations (#138)
  - Improvement of logging requests to relayer (#140)
  - Fix failed contract calls (#145)
@akolotov akolotov mentioned this pull request Jan 18, 2023
Merged
akolotov added a commit that referenced this pull request Jan 30, 2023
@akolotov
Merge the devel branch into the main branch, v3.1.0
5145117 
This merge contains the following set of changes:
  - Add debug log for RPC request errors (#131)
  - Add internal account validation (#135)
  - Add counter exceeded check for re-sent iterations (#138)
  - Improvement of logging requests to relayer (#140)
  - Fix failed contract calls (#145)
  - Add missed log (#149)
  - Add poolId validation (#154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@akolotov akolotov Awaiting requested review from akolotov

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry failed contract calls
3 participants
@lok52 @k1rill-fedoseev @akolotov