forked from zeropoolnetwork/zeropool-client-js
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dd tools #144
Merged
Merged
Feature/dd tools #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenKor
requested review from
maxaleks,
AllFi,
akolotov,
lok52,
k1rill-fedoseev and
r0wdy1
July 4, 2023 08:45
This was referenced Jul 4, 2023
akolotov
reviewed
Jul 4, 2023
k1rill-fedoseev
requested changes
Jul 6, 2023
Co-authored-by: Kirill Fedoseev <kirill@blockscout.com>
The latest changes:
|
r0wdy1
reviewed
Jul 10, 2023
r0wdy1
approved these changes
Jul 10, 2023
k1rill-fedoseev
approved these changes
Jul 10, 2023
AllFi
reviewed
Jul 10, 2023
AllFi
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced by that PR are intended to support direct deposits
directDeposit
to deposit funds to the current account via direct deposit scheme (both token and native scheme are supported through thetype
parameter:DirectDepositType.Token
\DirectDepositType.Native
).sendTxCallback
will invoked to send transaction andPreparedTransaction
is defined as following:isNative
(boolean
, should be set astrue
for WETH-pools to accept native direct deposits) andddSubgraph
(string
, the subgraph name to fetching pending direct deposits, currently supportedzkbob-bob-goerli
,zkbob-eth-goerli
andzkbob-bob-goerli-opt
)getPendingDDs
to fetch pending direct deposits in the queue (available just for pools with configured subgraphs). It returns an array ofDirectDeposit
objects:directDepositFee
which returns fee for the direct deposit in pool resolution (as returned by queue contract)directDepositContract
to retrieve DD queue contract address from the pooltokenSellerContract
to retrieve token seller contract address from the pool (also available in account-lessmode)This PR can be tested with associated console branch. Pending direct deposits are currently fetched in
BOB-goerli
,WETH-goerli
andBOB-op-goerli
poolPlease note
BOB-goerli
pool is currently migrated on USDC and require associated changes in denominator processing, implemented in #147, so testing that branch onBOB-goerli
pool is undesirable