Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented ability to add extra funds during gift-card creating #89

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Implemented ability to add extra funds during gift-card creating #89

merged 2 commits into from
Jul 10, 2023

Conversation

EvgenKor
Copy link

@EvgenKor EvgenKor commented Jul 7, 2023

With that changes you can set additional token amount to be sent to the gift-card during it's creation. It can use to get a fixed nominal during the redemption process after fee charging

image

Associated issue: zkBob/zkbob-client-js#135
Associated library PR: zkBob/zkbob-client-js#148

@EvgenKor EvgenKor mentioned this pull request Jul 7, 2023
Merged
AllFi
AllFi approved these changes Jul 10, 2023
View reviewed changes
Copy link

@AllFi AllFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@EvgenKor EvgenKor merged commit d390f60 into develop Jul 10, 2023
@EvgenKor EvgenKor deleted the feature/gift-card-add-extra-funds branch July 10, 2023 20:21
@EvgenKor EvgenKor mentioned this pull request Jul 10, 2023
Merged
EvgenKor added a commit that referenced this pull request Jul 10, 2023
@EvgenKor
Merging the develop branch into the main branch (v3.5.0)
c262031 
This merge contains the following set of changes:

- Sending direct deposits (tokens and native as well) to the account (#87)

- Prepared for review (#88)

- Implemented ability to add extra funds during gift-card creating (#89)
@r0wdy1 r0wdy1 mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@AllFi AllFi AllFi approved these changes

@akolotov akolotov Awaiting requested review from akolotov

@lok52 lok52 Awaiting requested review from lok52

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvgenKor @AllFi @k1rill-fedoseev