Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added migration configuration to display correct token symbol in history #88

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Added migration configuration to display correct token symbol in history #88

merged 2 commits into from
Jul 10, 2023

Conversation

EvgenKor
Copy link

@EvgenKor EvgenKor commented Jul 6, 2023

  • pool BOB-goerli was renamed to BOB2USDC-goerli and associated parameters were changed
  • added migration property in the config file (to display token names correctly in the history)
  • pool alias display in the prompt instead of network name currently

This branch should be tested with zkBob/zkbob-client-js#147

@EvgenKor EvgenKor mentioned this pull request Jul 6, 2023
Merged
@EvgenKor EvgenKor merged commit a5a31c2 into develop Jul 10, 2023
@EvgenKor EvgenKor deleted the feature/bob2usdc-migration branch July 10, 2023 20:16
@EvgenKor EvgenKor mentioned this pull request Jul 10, 2023
Merged
EvgenKor added a commit that referenced this pull request Jul 10, 2023
@EvgenKor
Merging the develop branch into the main branch (v3.5.0)
c262031 
This merge contains the following set of changes:

- Sending direct deposits (tokens and native as well) to the account (#87)

- Prepared for review (#88)

- Implemented ability to add extra funds during gift-card creating (#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@AllFi AllFi Awaiting requested review from AllFi

@akolotov akolotov Awaiting requested review from akolotov

@lok52 lok52 Awaiting requested review from lok52

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvgenKor @k1rill-fedoseev