Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atty is potentially unsound, not very alive and should be replaced with is-terminal #9

Closed
pacak opened this issue Nov 22, 2022 · 2 comments · Fixed by #10
Closed

atty is potentially unsound, not very alive and should be replaced with is-terminal #9

pacak opened this issue Nov 22, 2022 · 2 comments · Fixed by #10

Comments

@pacak
Copy link
Contributor

pacak commented Nov 22, 2022

Some links explaining the problem

I can prepare a pull request if you like
@pacak pacak mentioned this issue Nov 23, 2022
Merged
@zkat
Copy link
Owner

zkat commented Nov 23, 2022

thanks for posting this. Could I interest you in putting together a PR for this?

@pacak
Copy link
Contributor Author

pacak commented Nov 23, 2022

Looking. Support for on_cached seems a bit tricky.

@pacak pacak mentioned this issue Nov 25, 2022
Merged
@zkat zkat closed this as completed in #10 Dec 15, 2022
zkat pushed a commit that referenced this issue Dec 15, 2022
@pacak
fix(deps): Replace atty with is_terminal (#10)
edf565e 
Fixes: #9

BREAKING CHANGE: Exported stream types are no longer atty's getting re-exported.
@pacak pacak mentioned this issue Dec 16, 2022
Merged
@pacak pacak mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace atty with is_terminal pacak/supports-color
2 participants
@zkat @pacak