Replace atty with is_terminal

[pacak]

Fixes #9

[pacak]

Any thoughts?

[zkat]

Oh sorry, I don't know how this fell off my list.

[zkat]

This LGTM. It's unfortunate that it has to be a semver-major change, but that's my own fault for having re-exported atty types like that. Thank you!

[Porges]

I would argue that since the API is breaking anyway the exposed function should accept any IsTerminal, which makes the on function more general and flexible.

[pacak]

I would argue that since the API is breaking anyway the exposed function should accept any IsTerminal, which makes the on function more general and flexible.

Too late for that I'm afraid. Using IsTerminal required more changes to cached version of supports color request. Doable, but more complex and it would couple supports-color to is_terminal.

[Porges]

I would argue that since the API is breaking anyway the exposed function should accept any IsTerminal, which makes the on function more general and flexible.

Too late for that I'm afraid. Using IsTerminal required more changes to cached version of supports color request. Doable, but more complex and it would couple supports-color to is_terminal.

Maybe a feature-gated alternative function would be useful?

[zkat]

I definitely feel a bit weird that all the other supports-* crates would end up using IsTerminal, but supports-color wouldn't. I'm trying to figure out what would be best. I don't think it's inherently bad to couple to is-terminal if it's going to be a more permanent fixture in the cargo ecosystem, tbh.

[Porges]

I definitely feel a bit weird that all the other supports-* crates would end up using IsTerminal, but supports-color wouldn't. I'm trying to figure out what would be best. I don't think it's inherently bad to couple to is-terminal if it's going to be a more permanent fixture in the cargo ecosystem, tbh.

It will at some point be replaced by std::io::IsTerminal, so maybe the best thing to do is to expose the Stream-enum API for now and then switch to the trait when it is no longer unstable.