Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass LOAD_URL as param, and put LOAD_URL into .env #156

Merged
merged 1 commit into from
Feb 1, 2024
Merged

pass LOAD_URL as param, and put LOAD_URL into .env #156

merged 1 commit into from
Feb 1, 2024

Conversation

alvinlee001
Copy link
Contributor

No description provided.

@alvinlee001
Copy link
Contributor Author

@Divide-By-0 I am not sure if i do it correctly, this is for issue #150

@alvinlee001
Copy link
Contributor Author

Hi @Divide-By-0, am i doing it correctly?

@saleel saleel changed the base branch from main to develop February 1, 2024 14:58
@saleel
Copy link
Member

saleel commented Feb 1, 2024 •
edited
Loading

Thank you.
I am merging this to develop. There are some related PR, and we are also moving out the twitter example to another repo - so we can merge to main altogether.
I have made some of the changes you have in #163 without knowing about this PR - I will rebase there.

@saleel saleel merged commit 0a18d49 into zkemail:develop Feb 1, 2024
6 checks passed
@saleel saleel mentioned this pull request Feb 7, 2024
Merged
9 tasks
@alvinlee001
Copy link
Contributor Author

Thank you. I am merging this to develop. There are some related PR, and we are also moving out the twitter example to another repo - so we can merge to main altogether. I have made some of the changes you have in #163 without knowing about this PR - I will rebase there.

Hi @saleel , thanks for merging my code... I was hoping if this count as a contribution and eligible for a bounty? May i know the correct channel to apply for it?

Thanks again.

@Divide-By-0
Copy link
Member

Thank you. I am merging this to develop. There are some related PR, and we are also moving out the twitter example to another repo - so we can merge to main altogether. I have made some of the changes you have in #163 without knowing about this PR - I will rebase there.

Hi @saleel , thanks for merging my code... I was hoping if this count as a contribution and eligible for a bounty? May i know the correct channel to apply for it?

Thanks again.

Sure, please leave your eth address in the thread!

@alvinlee001
Copy link
Contributor Author

Thank you. I am merging this to develop. There are some related PR, and we are also moving out the twitter example to another repo - so we can merge to main altogether. I have made some of the changes you have in #163 without knowing about this PR - I will rebase there.

Hi @saleel , thanks for merging my code... I was hoping if this count as a contribution and eligible for a bounty? May i know the correct channel to apply for it?
Thanks again.

Sure, please leave your eth address in the thread!

Thanks @Divide-By-0 , my eth address is 0x1c9e88a60c74b519cbfdf589e5b5608553dc65be

@alvinlee001
Copy link
Contributor Author

Hi @Divide-By-0 , any updates?

@saleel saleel mentioned this pull request Mar 25, 2024
Closed
@Divide-By-0
Copy link
Member

Hi @Divide-By-0 , any updates?

Hey, sorry for delay. Will get to it ASAP

@Divide-By-0
Copy link
Member

@alvinlee001 Sent $50 on Optimism! https://optimistic.ethereum.io/tx/0x81027a1dfe40b992c2036a76efc242d9112176e21531258c4b1332a18f8c7019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvinlee001 @saleel @Divide-By-0