Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and cleanup in helpers #163

Merged
merged 17 commits into from
Feb 3, 2024
Merged

Refactoring and cleanup in helpers #163

merged 17 commits into from
Feb 3, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Jan 22, 2024

  • Try and update eml headers to revert ARC changes
  • Remove twitter specific code

Copy link

socket-security bot commented Jan 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/pki@1.1.0 None 0 120 kB marcus-sa

View full report↗︎

Copy link

socket-security bot commented Jan 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@saleel saleel changed the base branch from main to develop February 1, 2024 15:17
@Divide-By-0
Copy link
Member

Divide-By-0 commented Feb 2, 2024

packages/helpers/dist/zkp.d.ts
packages/helpers/dist/zkp.js

Btw, there should be a pre-commit hook that automatically re-compiles helpers/dist if there's a change in helpers/src!

@saleel saleel marked this pull request as ready for review February 3, 2024 06:24
@saleel
Copy link
Member Author

saleel commented Feb 3, 2024

packages/helpers/dist/zkp.d.ts
packages/helpers/dist/zkp.js

Btw, there should be a pre-commit hook that automatically re-compiles helpers/dist if there's a change in helpers/src!

We have build as part of publish so it gets rebuild before getting published to npm.

@saleel saleel merged commit d77e5a8 into develop Feb 3, 2024
4 of 6 checks passed
@saleel saleel deleted the feat/clean-helpers branch February 3, 2024 12:52
@saleel saleel mentioned this pull request Feb 7, 2024
9 tasks
This was referenced Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants