Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Pull from Mainframe loses the Toggle binary/text state of the current editor #302

Closed
JDUNNIN opened this issue Nov 15, 2019 · 6 comments · Fixed by #591
Closed

Bug: Pull from Mainframe loses the Toggle binary/text state of the current editor #302

JDUNNIN opened this issue Nov 15, 2019 · 6 comments · Fixed by #591
Assignees
@stepanzharychevbroadcom
Labels
bug Something isn't working USS

Comments

@JDUNNIN
Copy link

JDUNNIN commented Nov 15, 2019

If you have a file open in the editor and you pull from mainframe to get changes, the editor forgets the binary/text state and reloads the updated file (so it is no longer readable) and you have to press Toggle binary/text again.

The menu item for Toggle binary/text also seems to get out of sync when you've pulled from mainframe.
@JDUNNIN JDUNNIN changed the title Bug: Pulling from Mainframe loses the Toggle binary/text state of the current editor Bug: Pull from Mainframe loses the Toggle binary/text state of the current editor Nov 15, 2019
@Colin-Stone Colin-Stone added the bug Something isn't working label Nov 20, 2019
@MikeBauerCA MikeBauerCA added this to the Backlog milestone Nov 26, 2019
@jellypuno
Copy link
Contributor

@stepanzharychevbroadcom This is already fixed, right?

@jellypuno jellypuno added the USS label Mar 5, 2020
@stepanzharychevbroadcom
Copy link
Contributor

@jellypuno yes, it should be.

@JDUNNIN
Copy link
Author

JDUNNIN commented Mar 5, 2020

Thanks! :)

@zFernand0
Copy link
Member

@jellypuno @stepanzharychevbroadcom
PR, and Milestone?

@stepanzharychevbroadcom
Copy link
Contributor

@jellypuno @zFernand0 Just saw it connected with few binaries. Will do an investigation on latest master and create PR if it will be required.

@stepanzharychevbroadcom
Copy link
Contributor

@jellypuno @zFernand0 Fix is here: #591

@zFernand0 zFernand0 linked a pull request Mar 5, 2020 that will close this issue
Issue #302 #591
Merged
jellypuno added a commit that referenced this issue Mar 16, 2020
@jellypuno
Merge pull request #591 from zowe/fix/issue-302
62dd30a 
Issue #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stepanzharychevbroadcom stepanzharychevbroadcom

Labels
bug Something isn't working USS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #302 zowe/zowe-explorer-vscode
6 participants
@JDUNNIN @Colin-Stone @MikeBauerCA @zFernand0 @jellypuno @stepanzharychevbroadcom