Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #302 #591

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Issue #302 #591

merged 3 commits into from
Mar 16, 2020

Conversation

stepanzharychevbroadcom
Copy link
Contributor

Added saving of state for USS file during refreshing.

Signed-off-by: stepanzharychevbroadcom <stepan.zharychev@broadcom.com>
@jellypuno
Copy link
Contributor

@zFernand0 Do you know why the Build:Source is abending in the branch and not in the pr-merge?

Copy link
Contributor

@jellypuno jellypuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. I am able to click pull from mainframe and the file is toggled as binary

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          37       37           
  Lines        3481     3481           
  Branches      630      630           
=======================================
  Hits         3176     3176           
  Misses        302      302           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08214e...d91223d. Read the comment docs.

@zFernand0
Copy link
Member

Do you know why the Build:Source is abending in the branch and not in the pr-merge?

It could've failed for a number of reasons, however after updating from master, it seems to be fine now < ( ^ - ^ ) >

@jellypuno jellypuno merged commit 62dd30a into master Mar 16, 2020
@jellypuno jellypuno deleted the fix/issue-302 branch March 16, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pull from Mainframe loses the Toggle binary/text state of the current editor
3 participants