Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release config and add version to PNPM in README #3129

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Sep 19, 2024

Proposed changes

I modeled the changes after what was discussed in slack convo, adding back v1-lts if needed for final release too
Did keep release/3.* as pre-release for v3, only 1 more of them before GA, then this setting will become the patch release setting for v3 in follow up PR after last pre-release.
added the version of PNPM needed, 8,to top-level README with 9 out now

Release Notes

Milestone: v3 GA

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 19, 2024
@JillieBeanSim JillieBeanSim self-assigned this Sep 19, 2024
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added this to the v3.0.0 GA milestone Sep 19, 2024
@JillieBeanSim JillieBeanSim marked this pull request as ready for review September 19, 2024 19:19
Copy link

📅 Suggested merge-by date: 10/3/2024

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we intend on releasing another v3 pre-release, we'll have to temporarily update the config for the main branch to have prerelease: true and set its channel to next so that the Zowe Explorer API version is tagged as next on npm.

However, this would be a temporary change - after we're ready to release a GA version from main, we can remove the prerelease property and change the channel back to latest.

At that point, we should also add a configuration for the release/3.* wildcard that will publish as level: "patch" and channel: "zowe-v3-lts":

{
    name: "release/3.*",
    level: "patch",
    channel: "zowe-v3-lts"
}

This will allow us to publish patch versions for 3.x releases directly from the release/3.* branches.

@JillieBeanSim JillieBeanSim mentioned this pull request Sep 23, 2024
15 tasks
level: "patch"
},
{
name: "next",
name: "release/3.*",
Copy link
Contributor Author

@JillieBeanSim JillieBeanSim Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traeok I added this for the final pre-release, looking at the comment in our slack from @t1m0thyj isn't the plan to continue v3-lts minor releases against main. I may have misunderstood the conversation though...
After the final pre-release, we can update the release/3.x to become like a maintenance branch for patch releases with settings shared above
convo

Copy link
Member

@traeok traeok Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have clarified that the release/3.x branch implies any branch that starts with release/3.. For example, when we release 3.1, we can release patches from the release/3.1 branch without having to "filter out" enhancements that were already pushed into main after the 3.1 code freeze.

As for the final pre-release, I think we can release against main - once v3 is released as GA, we can make a branch release/3.0 (based on the latest changes on main). If we need to release a patch for 3.0, we can publish changes that are merged into that branch.

Copy link
Contributor Author

@JillieBeanSim JillieBeanSim Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a pre-release branch already built off of these changes and a PR for the final pre-release already created, and we would have to either change the release/3.* or the main config setting after the last pre-release regardless.

Copy link
Member

@traeok traeok Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, I see - that's another option we can take, so that sounds good to me. But yes, we'll have to change it regardless after the final pre-release 😁

Copy link
Contributor Author

@JillieBeanSim JillieBeanSim Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I can create the PR to update the release/3.* setting after last pre-release goes out, shooting for EOD tomorrow (9/24). We will need these changes merged in for upcoming pre-release to publish and my follow up PR for 3.0 patch publishing 😄

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (1ea9fab) to head (a3c1d6d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3129   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         113      113           
  Lines       11662    11662           
  Branches     2597     2557   -40     
=======================================
  Hits        10819    10819           
  Misses        841      841           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Billie for the updates!

@JillieBeanSim JillieBeanSim removed this from the v3.0.0 GA milestone Sep 23, 2024
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Sep 23, 2024
@zFernand0 zFernand0 removed their request for review September 23, 2024 20:25
Copy link
Contributor

@likhithanimma1 likhithanimma1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou @JillieBeanSim . LGTM

Copy link

@JillieBeanSim JillieBeanSim merged commit b5c05da into main Sep 24, 2024
29 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/release-conf branch September 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants