-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release config and add version to PNPM in README #3129
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
📅 Suggested merge-by date: 10/3/2024 |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we intend on releasing another v3 pre-release, we'll have to temporarily update the config for the main
branch to have prerelease: true
and set its channel to next
so that the Zowe Explorer API version is tagged as next
on npm
.
However, this would be a temporary change - after we're ready to release a GA version from main
, we can remove the prerelease
property and change the channel back to latest
.
At that point, we should also add a configuration for the release/3.*
wildcard that will publish as level: "patch"
and channel: "zowe-v3-lts"
:
{
name: "release/3.*",
level: "patch",
channel: "zowe-v3-lts"
}
This will allow us to publish patch versions for 3.x releases directly from the release/3.*
branches.
level: "patch" | ||
}, | ||
{ | ||
name: "next", | ||
name: "release/3.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traeok I added this for the final pre-release, looking at the comment in our slack from @t1m0thyj isn't the plan to continue v3-lts minor releases against main. I may have misunderstood the conversation though...
After the final pre-release, we can update the release/3.x to become like a maintenance branch for patch releases with settings shared above
convo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have clarified that the release/3.x
branch implies any branch that starts with release/3.
. For example, when we release 3.1, we can release patches from the release/3.1
branch without having to "filter out" enhancements that were already pushed into main
after the 3.1 code freeze.
As for the final pre-release, I think we can release against main
- once v3 is released as GA, we can make a branch release/3.0
(based on the latest changes on main
). If we need to release a patch for 3.0, we can publish changes that are merged into that branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, I see - that's another option we can take, so that sounds good to me. But yes, we'll have to change it regardless after the final pre-release 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, I can create the PR to update the release/3.*
setting after last pre-release goes out, shooting for EOD tomorrow (9/24). We will need these changes merged in for upcoming pre-release to publish and my follow up PR for 3.0 patch publishing 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 113 113
Lines 11662 11662
Branches 2597 2557 -40
=======================================
Hits 10819 10819
Misses 841 841
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Billie for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou @JillieBeanSim . LGTM
Quality Gate passedIssues Measures |
Proposed changes
I modeled the changes after what was discussed in slack convo, adding back v1-lts if needed for final release too
Did keep
release/3.*
as pre-release for v3, only 1 more of them before GA, then this setting will become the patch release setting for v3 in follow up PR after last pre-release.added the version of PNPM needed, 8,to top-level README with 9 out now
Release Notes
Milestone: v3 GA
Changelog: n/a
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments