Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final v3 prerelease #3136

Merged
merged 12 commits into from
Sep 25, 2024
Merged

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Sep 23, 2024

Proposed changes

Prepare final v3 pre-release

Waiting on these PRs:

Release Notes

Milestone: v3 pre-release

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 23, 2024
@JillieBeanSim JillieBeanSim self-assigned this Sep 23, 2024
@JillieBeanSim JillieBeanSim added this to the v3 pre-releases milestone Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (c1d216b) to head (d82c73d).
Report is 13 commits behind head on release/3.0.0-pre-release.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           release/3.0.0-pre-release    #3136   +/-   ##
==========================================================
  Coverage                      92.80%   92.80%           
==========================================================
  Files                            113      113           
  Lines                          11669    11669           
  Branches                        2594     2606   +12     
==========================================================
  Hits                           10829    10829           
  Misses                           838      838           
  Partials                           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-wolfe
Copy link
Contributor

We should also resolve the member node credential desync #3111.

@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Sep 23, 2024

We should also resolve the member node credential desync #3111.

Do we have an eta for this @t1m0thyj? Also an ETA for the port PR

It would be good to get last pre-release out by EOD tomorrow (9/23) with fixes requested from extenders and rest of fixes can be included in 3.0 GA or 3.0.1 patch

@t1m0thyj
Copy link
Member

@JillieBeanSim The port PR (#3135) is ready for review 😋 Planning to wrap up tests on the other PR (#3111) by EoD today.

@JillieBeanSim JillieBeanSim marked this pull request as ready for review September 24, 2024 13:23
Copy link

📅 Suggested merge-by date: 10/8/2024

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@zFernand0
Copy link
Member

zFernand0 commented Sep 24, 2024

Just to clarify, was the decision to test and merge #3149 in replacement of #3137?

Also, any objection to including these one?

…v3-final-prerelease

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim
Copy link
Contributor Author

Hey all, can we get the following PRs reviewed early Wed, 9/25, and possibly get this pre-release out possibly by lunch? @zFernand0 @t1m0thyj @traeok @likhithanimma1 @awharn @SanthoshiBoyina1 and @adam-wolfe

once merged I can update the release branches, if the PR have CHANGELOGs we can expect merge conflicts 😄 Thanks all!

zFernand0
zFernand0 previously approved these changes Sep 25, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining PRs are just waiting on reviews.
For now... this PR LTGM! 😋

…v3-final-prerelease

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the merge conflicts as other PRs where getting merged in 🙏🏽

Q: do we want to wait for the resolution of this comment?

@t1m0thyj
Copy link
Member

Q: do we want to wait for the resolution of this comment?

I'm investigating a fix for that now, but as it's more of an edge case I don't think it should hold up this prerelease 😋

@JillieBeanSim JillieBeanSim merged commit a601dbc into release/3.0.0-pre-release Sep 25, 2024
28 checks passed
@JillieBeanSim JillieBeanSim deleted the v3-final-prerelease branch September 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants